Skip to content

CA-393866: Add support for Infinity in Java SDK parser #5673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

danilo-delbusso
Copy link
Member

Example usage where Infinity is reported, corresponding to Double.POSITIVE_INFINITY 👇

image

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
@xueqingz
Copy link
Contributor

xueqingz commented Jun 7, 2024

Does this also works for "NaN"? I find three special float value need to be handled in our SDK: Infinity, Infinity, NaN

@danilo-delbusso
Copy link
Member Author

Does this also works for "NaN"? I find three special float value need to be handled in our SDK: Infinity, Infinity, NaN

good question and yes it does, see https://fasterxml.github.io/jackson-core/javadoc/2.10/com/fasterxml/jackson/core/json/JsonReadFeature.html#ALLOW_NON_NUMERIC_NUMBERS

We will obviously test this, too :)

@danilo-delbusso danilo-delbusso changed the title CA-393866: Add support for Infinity in Java SDK parser [ITE] CA-393866: Add support for Infinity in Java SDK parser Jun 10, 2024
@kc284 kc284 added the ITE label Jun 10, 2024
@kc284 kc284 changed the title [ITE] CA-393866: Add support for Infinity in Java SDK parser CA-393866: Add support for Infinity in Java SDK parser Jun 10, 2024
@kc284 kc284 merged commit 399595e into xapi-project:master Jun 10, 2024
13 checks passed
@danilo-delbusso danilo-delbusso deleted the bug/infinity_CA-393866 branch June 10, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants