Further improvements to pass traceparent XenAPI.py
#5672
Conversation
GabrielBuica
force-pushed
the
private/dbuica/CP-49633
branch
from
06f15aa to
f13d17a
Compare
GabrielBuica
changed the title
XenAPI.py
GabrielBuica
force-pushed
the
private/dbuica/CP-49633
branch
from
f13d17a to
f1e61bc
Compare
|
Passes BVT+BST 199742 & 199740, all components enabled and no tracing respectively |
|
after looking at the PR, this is my attempt to summarize the changes, @GabrielBuica are these correct?
|
|
That's correct @mg12! |
|
Could the explanation be added also to the commit message? |
|
Sure, I'll update the commit message as well. |
GabrielBuica
force-pushed
the
private/dbuica/CP-49633
branch
from
f1e61bc to
f31a780
Compare
|
Updated the commit message. |
|
I'll changed it to draft for the time being. With the changes from feature/perf merged, we are now reusing the initial connection, therefore subsequent spans of xapi requests appear in the under the wrong parent. |
`transport.make_connection` is now patched to pass a `traceparent` header when creating a non-local session. e.g. `XenAPI.Session(uri, transport)` This is meant as a follow up to e5bb639 that applied only to UDSTransport (local_login). It is more generic and it applies to anything derived from Transport, including UDSTransport, SafeTransport and Transport. The new behaviour is only present if otel=true, i.e. OTEL_SDK_DISABLED is set to `false` and required open-telemetry libs are present. Signed-off-by: Gabriel Buica <danutgabriel.buica@cloud.com>
GabrielBuica
force-pushed
the
private/dbuica/CP-49633
branch
from
f31a780 to
fb469b5
Compare
|
Can this PR be closed? Looks like it's not useful anymore |
The purpose of it is still the same: to be the general version of #5639. I will close it for now and keep the code on my branch (in case someone asks for it). |
Follow-up to: #5639.
This attempts to instrument non-local
XenAPI.pysessions.