-
Notifications
You must be signed in to change notification settings - Fork 292
CP-49116: Add Sha1 support to external_certificate_thumbprint_of_master. #5670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9cdb27a
to
b8182f0
Compare
23a6d5e
to
b80230a
Compare
b80230a
to
47e22b5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks readonable now, have you tested it on a host?
47e22b5
to
ca4a63a
Compare
Yep, it's all working, sha256 and sha1 are returned when there is a HOST_IS_SLAVE error and the appropriate header is given, and no header is returned otherwise, as shown below (where xrtmia-05-26 is slave and xrtmia-05-31 is master):
|
5b16918
to
72e5a74
Compare
equivalents. This allows support to be added to external_certificate_thumbprint_of_master for Sha1 fingerprints. Signed-off-by: Steven Woods <steven.woods@citrix.com>
72e5a74
to
5e51f8e
Compare
CP-49116: Add Sha1 support to external_certificate_thumbprint_of_master.
This change meant that the pp_hash function needed to be moved from certificates.ml to helpers.ml to prevent a circular dependency.