Updating CI #5641
Merged
Updating CI #5641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n python3/*.py Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
Signed-off-by: Stephen Cheng <stephen.cheng@cloud.com>
stephenchengCloud
force-pushed
the
local-tests-before-push-based-on-merge-5624
branch
from
58c2614 to
b973556
Compare
psafont
reviewed
May 21, 2024
| @@ -8,6 +8,10 @@ | |||
| import sys | |||
| import unittest | |||
| import mock | |||
| import pytest | |||
|
|
|||
| if sys.version_info > (2, ): | |||
There was a problem hiding this comment.
This will be easy to miss, ideally there's a task that tracks all the lines that need to be deleted before merging the branch to master. This could be done in ./qualitygate.sh
There was a problem hiding this comment.
Sure. Track this in https://issues.citrite.net/browse/CP-49148
psafont
approved these changes
May 21, 2024
liulinC
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is from @bernhardkaindl's PR #5626, and I just resubmitted it based on the latest code.
It is originally from 5504 which mainly aims to allow local CI check before pushing a PR.