CA-391381: Avoid errors for Partial Callables in observer.py #5638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psafont
reviewed
May 20, 2024
psafont
reviewed
May 20, 2024
lindig
approved these changes
May 20, 2024
There was a problem hiding this comment.
Added a suggestion to commit using a shorter variant of isinstance:
elif isinstance(wrapped, (types.FunctionType, types.MethodType)):and if using type is preferable, it can also be shortened to
elif type(wrapped) in [types.FunctionType, types.MethodType]:and added that https://sourcery.ai also says that the final else: pass is superflous, and hence, since the pass does nothing, the else: pass should be removable.
snwoods
force-pushed
the
private/stevenwo/CA-391381
branch
from
3931c74 to
aeae76f
Compare
This unblocks the Storage: BST to use distributed tracing as the sr_uuid parameter is sometimes not given. Signed-off-by: Steven Woods <steven.woods@citrix.com>
snwoods
force-pushed
the
private/stevenwo/CA-391381
branch
from
aeae76f to
84c8f1c
Compare
bernhardkaindl
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This unblocks the Storage: BST to use distributed tracing as the sr_uuid parameter is sometimes not given.
198342 is a passing suiterun with this change, compared to 198361 which errors as it does not have the change.
You can also compare 3967690 which was the initial job that found the issue, which now passes when rerun: 4003491