CP-49029: Instrument xapi_session.ml with tracing
#5621
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psafont
reviewed
May 10, 2024
lindig
approved these changes
May 10, 2024
|
What are the consecuences of missing the originator? If it's of little inconsequence it might be fine to have the optional argument, if it's important to not miss it, it probably needs to be forced. Independently I'd prefer to see an originator argument for with_tracing, and doing the covnersion there between originator and attributes: let with_tracing ~context ~originator name f =
let open Tracing in
let parent = context.tracing in
let span_attributes = Tracing.attributes_of_originator originator in
match
start_tracing_helper ?span_attributes:attributes (fun _ -> parent) name
with
... |
mg12
reviewed
May 10, 2024
GabrielBuica
force-pushed
the
private/dbuica/CP-49029
branch
from
3623de0 to
1aedd6d
Compare
psafont
approved these changes
May 16, 2024
mg12
approved these changes
May 17, 2024
Instruments `xapi_session.ml` to create span around session logins. Adds new attribute for spans: - `xs.xapi.session.originator` where available. Signed-off-by: Gabriel Buica <danutgabriel.buica@cloud.com>
GabrielBuica
force-pushed
the
private/dbuica/CP-49029
branch
from
1aedd6d to
8b889f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instruments
xapi_session.mlto create span around session logins.Adds new attribute for spans:
xs.xapi.session.originatorwhere available.