CP-47358, CP-47361: Generate convert functions Go code #5603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
duobei
commented
Apr 30, 2024
duobei
commented
- Add templates for convert functions
- Generate convert functions Go code
duobei
force-pushed
the
private/fezhan/CP-47358
branch
from
854f60a to
ac0480c
Compare
contificate
reviewed
Apr 30, 2024
minglumlu
reviewed
Apr 30, 2024
minglumlu
reviewed
Apr 30, 2024
minglumlu
approved these changes
Apr 30, 2024
minglumlu
reviewed
Apr 30, 2024
…unctions Signed-off-by: xueqingz <xueqing.zhang@citrix.com> Signed-off-by: Luca Zhang <feiya.zhang@cloud.com>
Signed-off-by: Luca Zhang <feiya.zhang@cloud.com>
duobei
force-pushed
the
private/fezhan/CP-47358
branch
from
ac0480c to
344e629
Compare
|
Checking the Go lint format pass with: root@3eea0d3e0e5d:/app/go/goSDK# golangci-lint run --config=/app/.golangci.yml
WARN The linter 'gomnd' is deprecated (since v1.58.0) due to: The linter has been renamed. Replaced by mnd.
WARN The linter 'execinquery' is deprecated (since v1.58.0) due to: The repository of the linter has been archived by the owner.
0 issues.Test with xenserver-samples Go project. No special issues found on 7b88aa5. |
|
The test Go files naming with different format , could we use same rules for all convert test go files? like xx_convert.go? |
xueqingz
reviewed
May 9, 2024
Sure. |
lindig
reviewed
May 9, 2024
Signed-off-by: Luca Zhang <feiya.zhang@cloud.com>
…lass messages Signed-off-by: Luca Zhang <feiya.zhang@cloud.com>
Signed-off-by: Luca Zhang <feiya.zhang@cloud.com>
…h_enums` Signed-off-by: Luca Zhang <feiya.zhang@cloud.com>
Signed-off-by: xueqingz <xueqing.zhang@citrix.com> Signed-off-by: Luca Zhang <feiya.zhang@cloud.com>
changed templates: APIVersions.mustache,APIErrors.mustache, Record.mustache Signed-off-by: Luca Zhang <feiya.zhang@cloud.com>
Signed-off-by: xueqingz <xueqing.zhang@citrix.com> Signed-off-by: Luca Zhang <feiya.zhang@cloud.com>
Signed-off-by: Luca Zhang <feiya.zhang@cloud.com>
Signed-off-by: Luca Zhang <feiya.zhang@cloud.com>
Signed-off-by: Luca Zhang <feiya.zhang@cloud.com>
duobei
force-pushed
the
private/fezhan/CP-47358
branch
from
7b88aa5 to
e2a4919
Compare
xueqingz
approved these changes
May 11, 2024
pytype_reporter extracted 50 problem reports from pytype output. You can check the results of the job here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.