Modify lshade.py #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Modified type checking code in line 66 to adapt Numpy's SeedSequence. 2. Removed repeated code in line 85
1. Add type conversion to the seed type checking modification. 2. replace deprecated np.float with float
Adapting to the case where seed is None
|
Hey there! I just wanted to let you know that I noticed some differences between the version I downloaded from Pip and the GitHub version. Maybe it would be good to consider updating the version on Pip? @xKuZz |
1. Add the determination of loss function convergence; 2. add the function to continue iterating for a period of time after convergence; 3. add the function to return the history of loss function convergence;
Add 'return_history': False to get_default_params
Fix type annotations on return values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified type checking code in line 66 to adapt Numpy's SeedSequence.
Removed repeated code in line 85