Skip to content

Exercices complétés #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 23 additions & 4 deletions numpy_questions.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
The goals of this assignment are:
* Use numpy in practice with two easy exercises.
* Use automated tools to validate the code (`pytest` and `flake8`)
* Submit a Pull-Request on github to practice `git`.
* Submit a Pull-Request on gitHub to practice `git`.

The two functions below are skeleton functions. The docstrings explain what
are the inputs, the outputs and the expected error. Fill the function to
Expand All @@ -15,6 +15,7 @@
This will be enforced with `flake8`. You can check that there is no flake8
errors by calling `flake8` at the root of the repo.
"""

import numpy as np


Expand All @@ -41,6 +42,19 @@ def max_index(X):
j = 0

# TODO
if not isinstance(X, np.ndarray):
raise ValueError("L'argument doit être une numpy array.")

forme = X.shape

if len(forme) != 2:
raise ValueError("L'argument doit être en 2D.")

n_samples, n_features = forme

index = np.argmax(X)
i = int(index // n_features)
j = int(index % n_features)

return i, j

Expand All @@ -62,6 +76,11 @@ def wallis_product(n_terms):
pi : float
The approximation of order `n_terms` of pi using the Wallis product.
"""
# XXX : The n_terms is an int that corresponds to the number of
# terms in the product. For example 10000.
return 0.
if n_terms == 0:
return 2

wal_pro = 1
for i in range(1, n_terms + 1):
wal_pro *= (4 * i ** 2) / ((4 * i ** 2) - 1)

return wal_pro * 2.
Loading