Skip to content

[TM-1850] Get sensitive ENV variables from github secrets #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2025

Conversation

roguenet
Copy link
Collaborator

https://gfw.atlassian.net/browse/TM-1850

I discovered yesterday that when we echo the ENV from github environments to the build environment, you can expand that little arrow and see all the values. Any user logged into Github, whether their part of our project or not can see them. So, we need to keep all secrets in their own secret definitions, and pull them out separately.

Next steps:

  • I'm going to delete all old completed actions for deployments, so that those secrets are no longer visible.
  • In a future ticket, we're going to need to rotate all of these values aside from DB_PASSWORD, which has always been a secret. That's going to be a big pain though, requiring a big synchronous update to the ENV of all 4 ENVs with updates to both PHP and v3. For now, simply removing the security problem is good enough.

@roguenet roguenet merged commit e9b584d into staging Mar 12, 2025
3 checks passed
@roguenet roguenet deleted the feat/TM-1850-hide-sensitive-env branch March 12, 2025 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants