[TM-1850] Get sensitive ENV variables from github secrets #85
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://gfw.atlassian.net/browse/TM-1850
I discovered yesterday that when we echo the ENV from github environments to the build environment, you can expand that little arrow and see all the values. Any user logged into Github, whether their part of our project or not can see them. So, we need to keep all secrets in their own secret definitions, and pull them out separately.
Next steps:
DB_PASSWORD
, which has always been a secret. That's going to be a big pain though, requiring a big synchronous update to the ENV of all 4 ENVs with updates to both PHP and v3. For now, simply removing the security problem is good enough.