Skip to content

Conversation

@Nikolar97
Copy link

TYPE: New feature

KEYWORDS: microphysic, forecast, cloud, precipitation

SOURCE: Ivan Ristic (Weather2 - www.weather2.rs)

DESCRIPTION OF CHANGES:
In order to improve cloud and precipitation forecast we developed new cloud prediction scheme and we implemented it in WRF model. Fractional cloud cover, cloud liquid water, cloud ice and cloud snow are explicitly predicted by adding three
prognostic equations for fractional cloud cover, cloud mixing ratio and snow per cloud fraction to the model. Sedimentation of ice and snow is also included in parameterization. Precipitation of rain and snow are determined from cloud fields. Clouds predicted like this can be used also in radiation parameterization.

Thermodynamic wet bulb temperature will be used for describing clouds because it is constant during water phase changes. By using this temperature moist static energy of model grid box and cloudy part inside the grid box is the same and principle of energy conservation is satisfied.

A complete description is now found in Ristic I., Kordic I., 2018: Cloud parameterization and cloud prediction scheme in the Eta numerical weather model. NWCM - Serbian Academy of Sciences and Arts which can be found at https://www.sanu.ac.rs/wp-content/uploads/2018/10/11_Cloud%20parameterization%20and%20cloud%20prediction%20scheme%20in%20Eta%20numerical%20weather%20model.pdf .

LIST OF MODIFIED FILES:
phys/Makefile
phys/module_microphysics_driver.F
phys/module_mp_ivanr_micro.F
Registry/Registry.EM_COMMON
Registry/Registry.NMM
dyn_em/solve_em.F
dyn_nmm/module_PHYSICS_CALLS.F
dyn_nmm/solve_nmm.F

TESTS CONDUCTED:
All the wrf-coop tests passed and the microphysics is being actively used for running a model with NMM.
Integration of the model for test cases indicate that new cloud prediction scheme improved forecast compared to the original model. New fractional cloud cover formula showed good results in practice, since the fractional cloud cover, predicted in this way, was much closer to the real cloud cover values. Significant progress has been made in stratiform precipitation forecast. Positive impact on convection scheme is also noticed.
One test was run on 17. November 2011 with the Wrf model with ECMWF as boundary data. Model run for 72 hours in horizontal resolution of about 22 km and vertical resolution of 38 layers for the Europe domain. Fog was first to be tested.
image
image

The second test was run on 24. June 2015 with Wrf model with ECMWF as boundary data. Model was run for 24 hours in
horizontal resolution of about 22 km and a vertical resolution of 38 layers for the Europe domain. The second test situation tested mid-morning precipitation over northern Serbia.
image

More details can be found in the aforementioned pdf file.

RELEASE NOTE: Ivan Ristic: Custom implementation of microphysics

@Nikolar97 Nikolar97 requested review from a team as code owners October 29, 2020 13:24
@dudhia
Copy link
Collaborator

dudhia commented Oct 29, 2020 via email

package p3_1category_nc mp_physics==51 - moist:qv,qc,qr,qi;scalar:qnc,qni,qnr,qir,qib;state:re_cloud,re_ice,vmi3d,rhopo3d,di3d,refl_10cm,th_old,qv_old
package p3_2category mp_physics==52 - moist:qv,qc,qr,qi,qi2;scalar:qnc,qni,qnr,qir,qib,qni2,qir2,qib2;state:re_cloud,re_ice,vmi3d,rhopo3d,di3d,vmi3d_2,rhopo3d_2,di3d_2,refl_10cm,th_old,qv_old
package morr_tm_aero mp_physics==40 - moist:qv,qc,qr,qi,qs,qg;scalar:qnc,qni,qns,qnr,qng;state:rqrcuten,rqscuten,rqicuten,EFCG,EFIG,EFSG,WACT,CCN1_GS,CCN2_GS,CCN3_GS,CCN4_GS,CCN5_GS,CCN6_GS,CCN7_GS,re_cloud,re_ice,re_snow,mskf_refl_10cm
package ivanr_micro mp_physics==150 - moist:qv,qc,qr,qs;scalar:qt;state:cld,tw2,pw2,qw2,f_snow
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dudhia @weiwangncar
Is there a better MP scheme value than 150?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davegill
We just used a random one that does not overlap with the others, whatever value is free can be used if 150 is too big/not following a rule.

@davegill
Copy link
Contributor

davegill commented Feb 9, 2021

@Nikolar97
Usually there is a "name" associated with the scheme. I have seen "ivanr" in the Registry. Would you prefer that the name formally be referred to as the "Ristic microphysics scheme"? If so, we'll add that to the information in the commit message title.

Comment on lines 1193 to 1197
state real cld ikj misc 1 - r "CLD" "w2id " ""
state real tw2 ikj misc 1 - r "TW2" "w2id " ""
state real pw2 ikj misc 1 - r "PW2" "w2id " ""
state real qw2 ikj misc 1 - r "QW2" "w2id " ""
state real f_snow ikj misc 1 - r "F_SNOW" "w2id " ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nikolar97
Please include a description of these fields with units. An example is the line directly above.
Since these are "r" restart variables, have you tested that you do indeed get reproducible results with a restart?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davegill
Added the descriptions to the fields in the EM_COMMON and NMM registry. The variables should be r, they were used in a similar way to other r fields in other custom schemes already in the model.

@davegill
Copy link
Contributor

davegill commented Feb 9, 2021

@weiwangncar @dudhia
Tangential to this PR ... why is "qt" (the total condensate mixing ratio) part of scalar, and not moist? The units are kg/kg.

@davegill davegill changed the title Adding a new microphysics Adding new Ristic microphysics scheme Feb 9, 2021
@dudhia
Copy link
Collaborator

dudhia commented Feb 9, 2021 via email

@Nikolar97
Copy link
Author

@davegill
Using the name "Ristic microphysics scheme" to formally refer to this scheme is fine.

Nikolar97 and others added 6 commits March 3, 2021 17:17
TYPE: text only

KEYWORDS: improve MAD-WRF section of README.namelist

SOURCE: internal + Pedro Jimenez

DESCRIPTION OF CHANGES:
Improve option description and refer to doc file

LIST OF MODIFIED FILES:
M run/README.namelist

TESTS CONDUCTED:
none needed
…#1517)

TYPE: bug fix

KEYWORDS: topo_wind option 1, data flag got_var_sso

SOURCE: reported by Y. Zhang, fixed by internal

DESCRIPTION OF CHANGES:
Problem:
topo_wind option 1 requires input field var_sso (variance of the subgrid scale orography). When program real is run, a
logical variable got_var_sso is defined upon checking whether the variance field exists or not. In the model, both
namelist option for topo_wind as well as this internal logical are required to use this topo_wind option. If got_var_sso
is not found when the topo_wind option is requested, the model produces an error "topo_wind requires VAR_SSO data",
even if the field VAR_SSO field itself exists in the input. When the model history file is used in a DA cycle, missing this
logical causes the model to stop.

Solution:
The registry file is modified to add 'got_var_sso' to the history file.

LIST OF MODIFIED FILES:
M Registry/Registry.EM_COMMON

TESTS CONDUCTED:

The modification has been tested to show it corrects the problem reported.
Jenkins tests are passing.
RELEASE NOTE: Logical variable got_var_sso is added to the history file for cycling DA application for use with the topo_wind option.
… WRFDA (wrf-model#1528)

Add mod_clddet_geoir.o as compilation dependency to da_radiance.o for WRFDA.

TYPE: bug fix

KEYWORDS: WRFDA,bug fix

SOURCE: "Marc Honnorat (EXWEXs)"

ISSUE: Fixes wrf-model#1527

LIST OF MODIFIED FILES:

var/build/depend.txt
RELEASE NOTE: Fixes compilation of WRFDA.
TYPE: text change

KEYWORDS: units in Registry

SOURCE: internal, Tzu-Chin Tsai (NTU)

DESCRIPTION OF CHANGES:
Problem:
The units for 7 new NTU microphysics variables are incorrectly specified in Registry.EM_COMMON.

Solution:
This PR corrects them.

LIST OF MODIFIED FILES:
M Registry/Registry.EM_COMMON

TESTS CONDUCTED:

Text change only. No effect on results
The Jenkins tests are all passing.
RELEASE NOTE: Units specified in Registry are corrected for several NTU microphysics variables.
@dudhia
Copy link
Collaborator

dudhia commented Sep 15, 2021

I am reminding the review panel to look at this scheme now.

weiwangncar and others added 4 commits September 15, 2021 14:12
TYPE: bug fix

KEYWORDS: eclipse module, radiation driver dependency

SOURCE: internal

DESCRIPTION OF CHANGES:
Problem:
The newly added module_ra_eclipse.F was not added to the dependency list of radiation driver. This sometimes causes compilation failures.

Solution:
Add module_ra_eclipse to radiation dependency list.

LIST OF MODIFIED FILES:
M main/depend.common

TESTS CONDUCTED:
- It is hard to test that there are no more intermittent build failures caused by this missing dependency. :)
- Jenkins tests are passing.
RELEASE NOTE: Adding module_ra_eclipse.o to radiation driver's dependency list to avoid occasional compilation failures.
TYPE: enhancement

KEYWORDS: Local Climate Zones (LCZ), urban parameters, urban canopy models

SOURCE: Matthias Demuzere (Ruhr University Bochum), Andrea Zonato (Trento University)

DESCRIPTION OF CHANGES:
Problem:
The values in the current version of the URBPARM_LCZ.TBL are specific for Zonato et al. (2020), reflecting city properties in Italy. Some of these values should be more universal.

Solution:
Changing some of the urban parameter values, to make them more generic. These universal values are based upon the following published materials:

Stewart ID, Oke TR. Local Climate Zones for Urban Temperature Studies. Bull Am Meteorol Soc. 2012;93(12):1879-1900. doi:10.1175/BAMS-D-11-00019.1
Stewart ID, Oke TR, Krayenhoff ES. Evaluation of the ‘local climate zone’ scheme using temperature observations and model simulations. Int J Climatol. 2014;34(4):1062-1080. doi:10.1002/joc.3746
Varentsov M, Samsonov T, Demuzere M. Impact of Urban Canopy Parameters on a Megacity’s Modelled Thermal Environment. Atmosphere (Basel). 2020;11(12):1349. doi:10.3390/atmos11121349

LIST OF MODIFIED FILES:
M run/URBPARM_LCZ.TBL

TESTS CONDUCTED:

Only concerns some parameter value changes.
Jenkins testing is all PASS.

RELEASE NOTE:
LCZ-specific urban canopy parameters values in URBPARM_LCZ.TBL are sourced from Stewart and Oke (2012), Stewart et al. (2014) and Varentsov et al. (2020) where available, and made more generic - the table values in 4.3 release are specific for Zonato et al. (2020). Still users are advised to check and adjust these for specific applications.
TYPE: bug fix

KEYWORDS: dimension, module_bc, spec_bdytend_perturb*

SOURCE: internal, Samm Elliott (TQI)

DESCRIPTION OF CHANGES:
Fixed a dimension error in perturbed bc routine

Problem:
Variables field_tend_perturb in spec_bdytend_perturb and field_scalar_perturb in spec_bdytend_perturb_chem should be dimensioned by jms:jme, but jms:kme was used.

Solution:
Fix the two dimension errors.

ISSUE: For use when this PR closes an issue.
Fixes wrf-model#1524

LIST OF MODIFIED FILES:
M share/module_bc.F

TESTS CONDUCTED:

It would be difficult to design a test to catch this bug.
The Jenkins tests are ok.

RELEASE NOTE: Fixed a dimensional errors in subroutine spec_bdytend_perburb and spec_bdytend_perturb_chem in module_bc.F. This routine is used to perturb fields on the model lateral boundaries for stochastic processing, and only affects results if perturb_bdy or perturb_chem_bdy are not 0 and they are 0 by default.
TYPE: text only

KEYWORDS: misspelling

SOURCE: Piotr Kasprzyk (IETU Katowice)

DESCRIPTION OF CHANGES:
Problem:
One misspelled letter in "required" word.

Solution:
Nothing was changed except for the wrong letter.

LIST OF MODIFIED FILES:
M       Registry/Registry.NMM

TESTS CONDUCTED: 
1. No tests were conducted since this is text only.
2. Jenkins tests are all PASS.
dudhia and others added 20 commits October 27, 2021 11:39
…l#1566)

TYPE: bug fix


KEYWORDS: module_stoch, RAND_PERT_UPDATE arguments

SOURCE: internal

DESCRIPTION OF CHANGES:
Problem:
In the initialization of the rand_perturb=1 option, the arguments to RAND_PERT_UPDATE were wrong.
The results would be that initially the stochastic perturbation had no cutoff standard deviations, but during 
the run this would have been corrected. Effect likely minor and generic rand_perturb option not used much.

Solution:
Correction so that argument list is same as from the call in first_rk_step_part2

LIST OF MODIFIED FILES: 
M       dyn_em/module_stoch.F

TESTS CONDUCTED: 
1. mod has been tested - Judith Berner is OK
2. Jenkins is OK

RELEASE NOTE: 
Fix in initialization for rand_perturb=1 option for the stochastic capabilities, due to an incorrect argument list. The effect is minor.
TYPE: text only

KEYWORDS: README file, version_decl

SOURCE: internal

DESCRIPTION OF CHANGES:
Update the top-level README file, and the inc/version_decl file with the correct version.

LIST OF MODIFIED FILES:
M README
M inc/version_decl

TESTS CONDUCTED: NA
Finalize WRFV4.3.1 by merging fixes from release-v4.3.1 branch onto master.
TYPE: bug fix

KEYWORDS: HPE, CCE, syntax

SOURCE: Tricia Balle (HPE)

DESCRIPTION OF CHANGES:
Problem:
There were three types of syntax errors that were uncovered by the HPE CCE compiler.
1. Open statement used `action="append"`.
2. Multiple unary operators next to each other `*+`
3. Multiple unary operators next to each other `*-1`.

Solution:
1. The correct usage is `position="append"`.
2. The developer agrees with the new modification to `GS3*+SASR1` was the original intent.
3. Typically, `*(-1)` is intended, and this is the case.

Via some grep'ing, no other occurrences of `*+` or `*-` exist in the physics directory in the compilable
source code. Syntactically OK source code with `/-` (such as for DATA statements) were the only compilable 
examples found. So, we fixed the above problems identified in this PR, and we could not find any other 
similar examples in the source code.

LIST OF MODIFIED FILES:
modified:   phys/module_mp_nssl_2mom.F
modified:   phys/module_mp_ntu.F
modified:   phys/module_sf_noahmplsm.F

TESTS CONDUCTED:
1. These fixes allow the WRF code to build with the CCE compiler.
2. Jenkins tests are all PASS.
3. One of the errors was a typo in the sink term of aggregates number from hail. A quick evaluation of its impact was
quite minor from the 2D idealized simulation (the figure is not shown).

RELEASE NOTE: A few syntax errors in NSSL, NTU, an NoahMP were fixed. Most compilers skipped over them. Either "small impact" or "no impact" for users for whom the code already compiled.
…of the net fuel load (wrf-model#1516)

TYPE: bug fix

KEYWORDS: fuel moisture initialisation, net fuel load computation, WRF-Fire

SOURCE: Theodore M. Giannaros (National Observatory of Athens, Greece)

DESCRIPTION OF CHANGES:
Problem:
Incorrect indexing in the initialization of fuel moisture content in subroutine `read_namelist_fire`, in WRF file 
`phys/module_fr_fire_phys.F`. 

Solution:
Changed `fmc_gc_initial_value(3)=fmc_1000h` to `fmc_gc_initial_value(4)=fmc_1000h` in subroutine 
`read_namelist_fire`, in WRF file `phys/module_fr_fire_phys.F`. 

LIST OF MODIFIED FILES: 
M phys/module_fr_fire_phys.F

TESTS CONDUCTED:
1. The correction applied resolved the erroneous initialization of both 1000h and 100h fuel moisture content. Prior 
to this correction, `fmc_gc_initial_value(3)=fmc_1000h` and no initialization was carried out for 
fmc_gc_initial_value(4). This resulted to erroneously setting `fmc_gc_initial_value(3)=fmc_1000h` and 
`fmc_gc_initial_value(4)=0` (was left uninitialized). Following the correction, both variables are correctly set 
(`fmc_gc_initial_value(3)=fmc_100h` and `fmc_gc_initial_value(4)=fmc_1000h`). 
2. Jenkins is all PASS.

RELEASE NOTE: Bug fix for fire module related to the initialization of 1000-h fuel moisture content due to an incorrect indexing assignment from the namelist entries for fuel classes.
TYPE: text only

KEYWORDS: correct misspellings

SOURCE: Piotr Kasprzyk (IETU Katowice)

DESCRIPTION OF CHANGES:
Problem:
The "pressure" spelling was wrong.

Solution:
Words "pressure" were corrected.

LIST OF MODIFIED FILES:
M       share/mediation_integrate.F
M       share/mediation_nest_move.F

TESTS CONDUCTED: 
1. Tests were not conducted, as this is a text only change.
2. Jenkins tests are all passing (as expected).
…1580)

TYPE: bug fix

KEYWORDS: ERA5, smooth_cg_topo, elevation data

SOURCE: internal

DESCRIPTION OF CHANGES:
Problem:
If a user does not include all of the correct ERA5 invariant files, then there could be
no soil elevation field coming from the metgrid program. Without that field, the flag
`flag_soilhgt` is not set. Then the real program will not generate any topo differences along
the lateral boundary (when requested with smooth_cg_topo = T). This is a quiet failure,
and difficult to track down.

Solution:
If the user asks to smooth the lateral boundary topo on d01, AND the user has no input
soil elevation data from the first-guess model, then this is now a fatal error.

LIST OF MODIFIED FILES:
modified:   dyn_em/module_initialize_real.F

TESTS CONDUCTED:
1. The original intent of the option still works - smoothed topo on d01 along the outer few rows and columns.
The first figure shows the change in topography. The second figure below shows which grid cells are
impacted. Basically, these two figures show that topography smoothing still is available.
<img width="1296" alt="Screen Shot 2021-11-05 at 11 27 03 AM" src="https://user-images.githubusercontent.com/12666234/140584624-40a71752-d718-44d3-8c3a-05f6fd710ee1.png">

<img width="1295" alt="Screen Shot 2021-11-05 at 11 45 57 AM" src="https://user-images.githubusercontent.com/12666234/140584653-f3546331-1c95-4ea3-a324-5f3a6e0cb3ee.png">

2. By artificially setting the metgrid flags in a debugging mode within the real program, we can successfully 
emulate missing soil elevation data by setting flag_soilhgt = 0. Whether or not we artificially set the value,
there is now a controlled stop to the real program.
```
-------------- FATAL CALLED ---------------
FATAL CALLED FROM FILE:  <stdin>  LINE:     766
 --- ERROR: NML option smooth_cg_topo=T, but no first guess soil elevation data
-------------------------------------------
```
3. All jenkins tests are PASS.

RELEASE NOTE: A fatal error in the real program is now issued when a user requests lateral boundary topography smoothing, but lacks the first-guess soil elevation data to do the weighted averaging of topography. Previously, this discrepancy was ignored, and the d01 high-resolution elevation data was quietly left undisturbed. We have seen this problem when a user chooses to initialize the model with ERA5 data, but when insufficient time invariant files are used.
TYPE: bug fix

KEYWORDS: configure, shell, echo

SOURCE: internal

DESCRIPTION OF CHANGES:
Problem:
When building with NetCDF that does not support compression, the warning statements that
are printed out are misaligned, due to missing trailing quotes at the end of some `echo` statements in the
`configure` script.

Solution:
Add those quotes back in.

LIST OF MODIFIED FILES:
modified:   configure

TESTS CONDUCTED: 
1. The printout is now aesthetically appealing. Initially we had a mortifying display of the word `echo`, and the 
accompanying alignment disarray that would be associated with banal shell scripting encroaching upon a user's otherwise elevated build experience:
```
Please make sure NETCDF version is 4.1.3 or later and was built with         
--enable-netcdf4                                                             

OR set NETCDF_classic variable                                               
   bash/ksh : export NETCDF_classic=1
      echo  csh : setenv NETCDF_classic 1
```
After much soul searching, an appropriate solution was uncovered, resulting in reduced messaging dissonance:
```
Please make sure NETCDF version is 4.1.3 or later and was built with         
--enable-netcdf4                                                             

OR set NETCDF_classic variable                                               
   bash/ksh : export NETCDF_classic=1                                        
        csh : setenv NETCDF_classic 1     
```
2. Jenkins is all PASS.
TYPE: no impact

KEYWORDS: Chem, photolysis, history

SOURCE: Jordan Schnell (NOAA)

DESCRIPTION OF CHANGES:
Remove photolysis rates not used by most modules from the default history stream.

LIST OF MODIFIED FILES: 
M       Registry/registry.chem

TESTS CONDUCTED:  None, remove history
1. Jenkins tests all PASS.

RELEASE NOTE: In WRF Chem, remove photolysis rates from the default history stream (these photolysis rates are not used by most modules).
…total loading of all bins. (wrf-model#1573)

TYPE: no impact

KEYWORDS: dustload5, dust, GOCART, Chem

SOURCE:  Jordan Schnell (NOAA), Yaping Shao (Universität zu Köln) & Martina Klose (Karlsruhe Institute of Technology (KIT))

DESCRIPTION OF CHANGES:
Changes the description of "dustload5" to be the load in size bin 5, not the total loading of all bins.

LIST OF MODIFIED FILES:
M       Registry/registry.chem

TESTS CONDUCTED: 
1. Jenkins tests are all PASS.
TYPE: bug fix

KEYWORDS: CLM, PCT_PFT

SOURCE: internal

DESCRIPTION OF CHANGES:
Problem:
CLM specific variable PCT_PFT appears in standard wrfout file, even if CLM option is not selected.

Solution:
The packaged variable name should be pct_pft_input, rather than pct_pft.

LIST OF MODIFIED FILES: 
Registry/Registry.EM_COMMON

TESTS CONDUCTED: 
1. The change removes PCT_PFT from wrfout file when CLM option is not selected.
2. The Jenkins tests are all passing.

RELEASE NOTE: Starting with release-v4.3, the CLM specific variable PCT_PFT appeared in standard wrfout file, even when the CLM option was not selected. A small modification to the standard Registry file removed this incorrectly output 3d array. Other than removing this innocuous zero-valued 3d array from the output stream, there is no other impact for users.
)

TYPE: bug fix

KEYWORDS: syntax, physics, *+

SOURCE: Patricia Balle (HPE)

DESCRIPTION OF CHANGES:
Problem:
As in hash 7c6fd57, PR wrf-model#1577 "Syntax errors in physics routines: *- and *+", there is a single
remaining example of the unary operators next to each other.

Solution:
The author agreed that the `*+` combination was supposed to be just `+`.

I searched the WRF code for instances of this `*+` in PR wrf-model#1577. When I did not find any, I put back one of them from 
NTU code to make sure that my grep was working. It found that example, and no others that I cared about. I forgot
to undo that change before the `git add`, `git commit`.

LIST OF MODIFIED FILES:
modified:   phys/module_mp_ntu.F

TESTS CONDUCTED:
1. Passes Cray compiler.
2. Jenkins tests are OK
TYPE: bug fix (?)

KEYWORDS: WRFDA, CRTM, ftn compiler

SOURCE: Jamie Bresch (NCAR)

DESCRIPTION OF CHANGES:
Problem:
One of the CRTM modules does not compile with Cray Fortran : Version 12.0.3 with default or -O2 optimization.
ftn -hnoomp -c -N1023 -f free -h byteswapio SOI_Module.f90

ERROR - Trying to add using unusual type properties
  op1_type :: <array[t$90] of real*8>
  op2_type :: <array[t$90] of real*8>
   Error message      ::  Optimization internal error
   Error detected     ::  File 'pdgcs/v_expr_pls.c', line 197
   Optimizer built    ::  2021-08-16 (production)
   File               ::  SOI_Module.f90
   Function           ::  crtm_soi_ad
   at or near line    ::  656

Solution:
Edit CRTM makefile to compile SOI_Module.f90 with -O1 flag when ftn compiler is used.

LIST OF MODIFIED FILES:
M var/external/crtm_2.3.0/libsrc/makefile

TESTS CONDUCTED:
1. WRFDA builds on Cheyenne crayenv after the fix. (note that configure.wrf has to be edited to uncomment two lines that specify LIB_LOCAL as noted in 207c89e)
2. Jenkins tests passed.

RELEASE NOTE: N/A
TYPE:enhancement

KEYWORDS: ARM 

DESCRIPTION OF CHANGES:
Problem:
There are no ARM-only stanzas in arch/configure.defaults. As the suggestion from wrf-model#1535 , we need a separate PR for ARM specific update.

Solution:
Edit the arch/configure.defaults file and add a stanza for aarch64 and armv7l, using the GNU compiler options. 

The default optimization is -03, up from the usual -02. On two 36-h nested simulations on a raspberry pi, the 
difference is a consistent 3% speed increase across the radiation and non-radiation time steps. This used CONUS, 
so the -03 option seems reasonably robust with the GNU compiler.

LIST OF MODIFIED FILES:
M arch/configure.defaults

RELEASE NOTE: Added a new stanza that is only for ARM processors (right now aarch64 and armv7l) with GNU.
TYPE: bug fix

KEYWORDS: PBL, LES

SOURCE: internal

DESCRIPTION OF CHANGES:
Problem:
A few PBL schemes include scalar components that are advected. These fields are
required on all domains. With an LES option on a finer domain, that grid does not
have the additional scalar component, which causes a segfault when trying to
access that field.

Solution:
Restrict what PBL schemes are eligible for use with the LES (no PBL) option.

ISSUE:
Fixes wrf-model#1514

LIST OF MODIFIED FILES:
modified:   Registry/Registry.EM_COMMON
modified:   share/module_check_a_mundo.F

TESTS CONDUCTED:
1. When an incompatible CG PBL and FG LES are selected, the code successfully stops.
```
 &physics
 bl_pbl_physics                      =  5,     0,

--- ERROR: LES PBL on fine grid does not work with CG PBL option  5
           Choose a CG PBL option without any scalar components
           Fix bl_pbl_physics in namelist.input
           Alternatively, remove all of the packaged variables from the CG PBL selection
-------------- FATAL CALLED ---------------
FATAL CALLED FROM FILE:  <stdin>  LINE:    2523
NOTE:       1 namelist settings are wrong. Please check and reset these options
```
```
 &physics
 bl_pbl_physics                      =  6,     0,

--- ERROR: LES PBL on fine grid does not work with CG PBL option  6
           Choose a CG PBL option without any scalar components
           Fix bl_pbl_physics in namelist.input
           Alternatively, remove all of the packaged variables from the CG PBL selection
-------------- FATAL CALLED ---------------
FATAL CALLED FROM FILE:  <stdin>  LINE:    2523
NOTE:       1 namelist settings are wrong. Please check and reset these options
```
```
 &physics
 bl_pbl_physics                      = 16,     0,

--- ERROR: LES PBL on fine grid does not work with CG PBL option  16
           Choose a CG PBL option without any scalar components
           Fix bl_pbl_physics in namelist.input
           Alternatively, remove all of the packaged variables from the CG PBL selection
-------------- FATAL CALLED ---------------
FATAL CALLED FROM FILE:  <stdin>  LINE:    2523
NOTE:       1 namelist settings are wrong. Please check and reset these options
```
2. All jenkins tests are a PASS.

RELEASE NOTE: A test was introduced to stop the incorrect combination of particular PBL schemes on coarser grids with the LES PBL option selected on a finer grid. Previously, this problem caused an inconsistent number of variables on the CG and FG, which caused segmentation faults when trying to do feedback or advection of unavailable fields.
…el#1598)

TYPE: enhancement

KEYWORDS: time-varying greenhouse gases, RRTMG-sw

SOURCE: internal

DESCRIPTION OF CHANGES:
Problem:
Time-varying greenhouse gases were added to the WRF code in 2013. It was added to CAM longwave and shortwave options. But it was only added to RRTMG longwave scheme. 

Solution:
1. After consulting with the original contributors of the code, the time-varying gases are added to the RRTMG-sw and RRTMG-swf code in this PR. 
2. Also included in this PR is to remove dependency of clwrf_support code for RRTMG-lwk (KIM version) - that code does not use the capability. 

In a single 15 km domain test in July 2018, there are small differences between temperature and height at 24 h forecast time as shown below in the domain averaged profile plot:
![diff2](https://user-images.githubusercontent.com/12705680/145914692-c968b3d9-f807-4932-b86d-39abf0855fe8.png)


LIST OF MODIFIED FILES: 
M       main/depend.common
M       phys/module_ra_rrtmg_sw.F
M       phys/module_ra_rrtmg_swf.F

TESTS CONDUCTED: 
1. Time varying gases are added to RRTMG-swf and RRTMG-sw
2. The Jenkins tests all passing.

RELEASE NOTE: Added time-varying greenhouse gases to RRTMG shortwave options: RRTMG and RRTMG-fast.
…ration for release (wrf-model#1599)

Update top-level README and inc/version_decl files to v4.3.2 in preparation for release

TYPE: text only

KEYWORDS: update, README, version_decl, v4.3.2, release

SOURCE: Internal

DESCRIPTION OF CHANGES:
Updated the top-level README and inc/version_decl files to v4.3.2 in preparation for release

LIST OF MODIFIED FILES:
M README
M inc/version_decl

TESTS CONDUCTED:

No tests needed
Jenkins tests passed.
@davegill
Copy link
Contributor

@Nikolar97
Nikola,
Your merge did not go well.
I started with the top of the develop branch and cherry-picked your two commits: 00f89fc and 307c9da. The "new" PR for this is "Adding Ristic microphysics scheme" #1619.
I am closing this PR.

@davegill davegill closed this Dec 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.