Skip to content

Martinh/ntt support #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 17, 2025
Merged

Martinh/ntt support #463

merged 4 commits into from
Jun 17, 2025

Conversation

martin0995
Copy link
Collaborator

Description

Update ntt supported tables using this file as reference.

Related to: papermoonio/wormhole-mkdocs#268

Checklist

  • Required - I have added a label to this PR 🏷️
  • Required - I have run my changes through Grammarly
  • If pages have been moved, I have created redirects in the wormhole-mkdocs repo

@martin0995 martin0995 added the A2 - Maintenance Minor Pull request contains minor updates to an existing page (i.e., modifying parameters, steps, etc.) label Jun 11, 2025
@martin0995 martin0995 added the B0 - Needs Review Pull request is ready for review label Jun 11, 2025
Copy link
Collaborator

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of these changes include changing Kaia back to Klaytn. But I think we should keep it as Kaia: https://x.com/klaytn_official?lang=en

I opened a PR along time ago to update the Wormhole SDK so it used Kaia instead, but I think it got lost in the sauce and I also tried updating the docs in that PR (probably unsuccessfully) so if I were them I probably just would have closed it 😆 - but I think it's still picking up dust somewhere 🌈

Maybe "Kaia (previously Klaytn)"?

@martin0995
Copy link
Collaborator Author

Some of these changes include changing Kaia back to Klaytn. But I think we should keep it as Kaia: https://x.com/klaytn_official?lang=en

I opened a PR along time ago to update the Wormhole SDK so it used Kaia instead, but I think it got lost in the sauce and I also tried updating the docs in that PR (probably unsuccessfully) so if I were them I probably just would have closed it 😆 - but I think it's still picking up dust somewhere 🌈

Maybe "Kaia (previously Klaytn)"?

Is Klaytn off? We are fetching updated data from this file, which Wormhole updates frequently

@eshaben
Copy link
Collaborator

eshaben commented Jun 13, 2025

Is Klaytn off? We are fetching updated data from this file, which Wormhole updates frequently

That's what I'm trying to say, like I opened a PR against the SDK to update the names across the board so that the entire SDK would be using the correct name. But it didn't go anywhere. Regardless, Klaytn has official announcements saying they're now Kaia. So we should keep it as Kaia and if anything we can add (previously Klaytn) in parenthesis or something. But we shouldn't now be going backwards to Klaytn.

@martin0995 martin0995 requested a review from eshaben June 16, 2025 09:10
Copy link
Collaborator

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!

@martin0995 martin0995 added B1 - Ready to Merge Pull request is ready to be merged and removed B0 - Needs Review Pull request is ready for review labels Jun 17, 2025
@ilariae ilariae merged commit 3654e44 into main Jun 17, 2025
2 checks passed
@ilariae ilariae deleted the martinh/ntt-support branch June 17, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A2 - Maintenance Minor Pull request contains minor updates to an existing page (i.e., modifying parameters, steps, etc.) B1 - Ready to Merge Pull request is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants