-
Notifications
You must be signed in to change notification settings - Fork 26
Token Bridge Feedback #448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
albertov19
wants to merge
59
commits into
main
Choose a base branch
from
albertov19/token-bridge-feedback
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
59 commits
Select commit
Hold shift + click to select a range
7abbc0d
wip
eshaben a690f89
reorganize content to new structure
eshaben 5dc1e37
Merge remote-tracking branch 'origin' into staging-new-ia
eshaben a149aa9
update llms
eshaben 990adbf
add support for tool selector
eshaben 99c55cc
add logic so the dropdown closes when a user clicks anywhere else on …
eshaben 66cbbdc
update messaging tutorial .pages file
eshaben 209f970
move ai resources to a directory
eshaben ac88301
Queries - Get Started page (#377)
martin0995 02370ff
NTT - Get Started page (#376)
martin0995 8c212e0
move tools
eshaben 7fe8e30
Connect - Get Started page (#375)
dawnkelly09 ba6c0da
Messaging - Get Started (#381)
dawnkelly09 2d9d111
Queries - Overview (#388)
ilariae 46a0fe9
Messaging - Overview (#387)
ilariae 1411849
Multigov - Overview (#397)
ilariae cc3b7b9
Pull the latest changes into staging (#404)
eshaben 2609cea
Multigov - Get Started page (#379)
martin0995 086ed52
remove dropdown js used for tools
eshaben 6c018e6
link fixes (#407)
ilariae 129ddc0
Typescript SDK - Get Started page (#380)
martin0995 50001c0
Token Bridge - Get Started page (#382)
martin0995 b363ada
Update Diagrams (#414)
ilariae bff4217
Token Bridge Payload Structure (#422)
ilariae 27797a0
Overview - Token Bridge (#410)
ilariae 9d01cda
CCTP - Get Started page (#408)
martin0995 ef9cba5
Overview - Connect (#412)
Telucero bede78c
add supported networks page (#431)
eshaben cc7c1df
Taylor/supported methods (#428)
Telucero 37d1d79
Token Bridge Transfer Flow (#419)
eshaben b096f7a
Overview - Native Token Tranfers (#413)
Telucero b3fd70a
Overview - Settlement (#420)
ilariae 0f0325b
Overview - CCTP bridge (#411)
Telucero 8bd17b3
Updated Get Started with Messaging + Solidity SDK Get Started (#401)
dawnkelly09 3f9625b
Solidity SDK temporary clean up (#434)
eshaben 9007110
Pull in latest changes from main to the staging branch (#436)
eshaben 356987c
Clean up old pages on the staging branch (#437)
eshaben 543a4d7
Update the TypeScript SDK section (#433)
eshaben f7b307d
Settlement - Get Started page (#378)
martin0995 8870c49
use queries page (#432)
ilariae 4951ec4
Ilariae/todos (#441)
ilariae 141366c
clean up ntt (#438)
ilariae 06d7f34
update llms
eshaben e715eba
Ilariae/clean up lists (#442)
ilariae dde141b
update links (#443)
eshaben b92ec39
update llms
eshaben 0647677
fix a few remaining 404s (#444)
eshaben bab713f
update table
eshaben a3361a5
updates to token bridge
albertov19 062c09e
grammarly
albertov19 203056f
llm check
martin0995 27c63cf
Update products/token-bridge/guides/attest-tokens.md
martin0995 4f016a5
Update products/token-bridge/guides/attest-tokens.md
martin0995 4571563
Update products/token-bridge/guides/attest-tokens.md
martin0995 d342a8d
Apply suggestions from code review
martin0995 508be14
Apply suggestions from code review
martin0995 3c8844e
add prerequisites as suggested by reviewers
martin0995 d35b949
llm check
martin0995 33ed4c8
llm check
martin0995 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
8 changes: 8 additions & 0 deletions
8
.snippets/code/products/messaging/guides/core-contracts/attestToken.sol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
IWormhole wormhole = IWormhole(wormholeAddr); | ||
|
||
uint256 wormholeFee = wormhole.messageFee(); | ||
|
||
wormhole.attestToken{value: wormholeFee}( | ||
address(tokenImpl), // the token contract to attest | ||
234 // nonce for the transfer | ||
); |
14 changes: 14 additions & 0 deletions
14
.snippets/code/products/messaging/guides/core-contracts/transferTokens.sol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
IWormhole wormhole = IWormhole(wormholeAddr); | ||
ITokenBridge tokenBridge = ITokenBridge(tokenBridgeAddr); | ||
|
||
// Get the fee for publishing a message | ||
uint256 wormholeFee = wormhole.messageFee(); | ||
|
||
tokenBridge.transferTokens{value: wormholeFee}( | ||
token, // address of the ERC-20 token to transfer | ||
amount, // amount of tokens to transfer | ||
recipientChain, // Wormhole chain ID of the destination chain | ||
recipient, // recipient address on the destination chain (as bytes32) | ||
arbiterFee, // fee for relayer | ||
nonce // nonce for this transfer | ||
); |
14 changes: 14 additions & 0 deletions
14
.snippets/code/products/messaging/guides/core-contracts/transferTokensWithPayload.sol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
IWormhole wormhole = IWormhole(wormholeAddr); | ||
ITokenBridge tokenBridge = ITokenBridge(tokenBridgeAddr); | ||
|
||
// Get the fee for publishing a message | ||
uint256 wormholeFee = wormhole.messageFee(); | ||
|
||
tokenBridge.transferTokensWithPayload{value: wormholeFee}( | ||
token, // address of the ERC-20 token to transfer | ||
amount, // amount of tokens to transfer | ||
recipientChain, // Wormhole chain ID of the destination chain | ||
recipient, // recipient address on the destination chain (as bytes32) | ||
nonce, // nonce for this transfer | ||
additionalPayload // additional payload data | ||
); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.