Skip to content

Rename all_pb_names to all_product_block_names and refactor related logic #968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

saket-geant
Copy link
Contributor

@saket-geant saket-geant commented Jun 9, 2025

currently draft

Copy link

codspeed-hq bot commented Jun 9, 2025

CodSpeed Performance Report

Merging #968 will not alter performance

Comparing bug/914-allPbNames-issue (86a0293) with main (fc4c57e)

Summary

✅ 12 untouched benchmarks

Copy link

codecov bot commented Jun 9, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.85%. Comparing base (fc4c57e) to head (86a0293).

Files with missing lines Patch % Lines
orchestrator/graphql/schemas/product.py 75.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #968      +/-   ##
==========================================
- Coverage   83.87%   83.85%   -0.02%     
==========================================
  Files         210      210              
  Lines       10186    10188       +2     
  Branches     1003     1004       +1     
==========================================
  Hits         8543     8543              
- Misses       1376     1377       +1     
- Partials      267      268       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.


return names
names = set(get_names(model.product_blocks, set()))
return sorted(names)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

There is a fixture test/unit_tests/fixtures/products/product_blocks/product_block_one_nested.py which has recursive product block relations.

Could you add a testcase using that fixture to test the recursion case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants