Skip to content

Extract release notes lines to an array to later join it #644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 14, 2025

Conversation

iangmaia
Copy link
Contributor

@iangmaia iangmaia commented Apr 14, 2025

Internal reference: p1744652620596379-slack-C06CKSPHYA1

What does it do?

There was an issue in the code due to the recent frozen_string_literal update and the fact that we're modifying with chomp! a String pre-initialized with an empty value.
I've updated the code a bit to extract the lines first to an array to later join + chomp it.

Checklist before requesting a review

  • Run bundle exec rubocop to test for code style violations and recommendations.
  • Add Unit Tests (aka specs/*_spec.rb) if applicable.
  • Run bundle exec rspec to run the whole test suite and ensure all your tests pass.
  • Make sure you added an entry in the CHANGELOG.md file to describe your changes under the appropriate existing ### subsection of the existing ## Trunk section.
  • If applicable, add an entry in the MIGRATION.md file to describe how the changes will affect the migration from the previous major version and what the clients will need to change and consider.

@iangmaia iangmaia added the bug Something isn't working label Apr 14, 2025
@iangmaia iangmaia requested review from danielebogo and a team April 14, 2025 18:28
@iangmaia iangmaia self-assigned this Apr 14, 2025
@iangmaia iangmaia merged commit d854e0f into trunk Apr 14, 2025
6 checks passed
@iangmaia iangmaia deleted the iangmaia/fix-release-notes-extraction branch April 14, 2025 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants