Skip to content

Handle 429 and prevent 301 in gp_downloadmetadata #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 6, 2022
Merged

Handle 429 and prevent 301 in gp_downloadmetadata #406

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b8c44c4
Update `gp_downloadmetadata` to offer to retry when receiving a 429
mokagio Sep 6, 2022
80af526
Update a couple of `puts` in `gp_downloadmetadata` to `UI.message`
mokagio Sep 6, 2022
31daea9
Add more UI messages to `gp_downloadmetadata`
mokagio Sep 6, 2022
0af9cfa
Add trailing `/` to URL used by `gp_downloadmetadata` to avoid 301
mokagio Sep 6, 2022
60106a5
Show user unhandled `gp_downloadmetadata` errors and ask to continue
mokagio Sep 6, 2022
eafb2ed
Add `CHANGELOG.md` entry for #406
mokagio Sep 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,15 @@

### Breaking Changes

_None_
- Propose to retry when `gp_downloadmetadata` receives a `429 - Too Many Requests` error. [#406]
Copy link
Contributor

@AliSoftware AliSoftware Sep 9, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mokagio I'm not sure this is really a breaking change — as in, that won't require any change to client repos adopting the new release-toolkit to update their call sites or config or whatnot, will it?

I think it's not worth a major version bump on the next release, while a New Feature and minor bump would make more sense for this change 🙃

Copy link
Contributor Author

@mokagio mokagio Sep 12, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, not at all a breaking change. That was an oversight which I realized only after merging this. It's fixed in 39808da.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, perfect, thanks for following-up 👍


### New Features

_None_

### Bug Fixes

_None_
- Update the URL used by `gp_downloadmetadata` to prevent consistent `301` responses. [#406]

### Internal Changes

Expand Down