Replace is_string: false booleans with type: Boolean

spencertransier · spencertransier · commit caf9b47e3a25 · 2023-04-26T14:34:32.000-07:00
diff --git a/lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_betabuild_prechecks.rb b/lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_betabuild_prechecks.rb
@@ -79,7 +79,7 @@ def self.available_options
           FastlaneCore::ConfigItem.new(key: :skip_confirm,
                                        env_name: 'FL_ANDROID_BETABUILD_PRECHECKS_SKIPCONFIRM',
                                        description: 'Skips confirmation',
-                                       is_string: false, # true: verifies the input is a string, false: every kind of value
+                                       type: Boolean,
                                        default_value: false), # the default value if the user didn't provide one
           FastlaneCore::ConfigItem.new(key: :default_branch,
                                        env_name: 'FL_RELEASE_TOOLKIT_DEFAULT_BRANCH',
diff --git a/lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_build_prechecks.rb b/lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_build_prechecks.rb
@@ -46,22 +46,22 @@ def self.available_options
           FastlaneCore::ConfigItem.new(key: :skip_confirm,
                                        env_name: 'FL_ANDROID_BUILD_PRECHECKS_SKIP_CONFIRM',
                                        description: 'True to avoid the system ask for confirmation',
-                                       is_string: false,
+                                       type: Boolean,
                                        default_value: false),
           FastlaneCore::ConfigItem.new(key: :alpha,
                                        env_name: 'FL_ANDROID_BUILD_PRECHECKS_ALPHA_BUILD',
                                        description: 'True if this is for an alpha build',
-                                       is_string: false,
+                                       type: Boolean,
                                        default_value: false),
           FastlaneCore::ConfigItem.new(key: :beta,
                                        env_name: 'FL_ANDROID_BUILD_PRECHECKS_BETA_BUILD',
                                        description: 'True if this is for a beta build',
-                                       is_string: false,
+                                       type: Boolean,
                                        default_value: false),
           FastlaneCore::ConfigItem.new(key: :final,
                                        env_name: 'FL_ANDROID_BUILD_PRECHECKS_FINAL_BUILD',
                                        description: 'True if this is for a final build',
-                                       is_string: false,
+                                       type: Boolean,
                                        default_value: false),
         ]
       end
diff --git a/lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_codefreeze_prechecks.rb b/lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_codefreeze_prechecks.rb
@@ -57,7 +57,7 @@ def self.available_options
           FastlaneCore::ConfigItem.new(key: :skip_confirm,
                                        env_name: 'FL_ANDROID_CODEFREEZE_PRECHECKS_SKIPCONFIRM',
                                        description: 'Skips confirmation before codefreeze',
-                                       is_string: false, # true: verifies the input is a string, false: every kind of value
+                                       type: Boolean,
                                        default_value: false), # the default value if the user didn't provide one
           FastlaneCore::ConfigItem.new(key: :default_branch,
                                        env_name: 'FL_RELEASE_TOOLKIT_DEFAULT_BRANCH',
diff --git a/lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_completecodefreeze_prechecks.rb b/lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_completecodefreeze_prechecks.rb
@@ -40,7 +40,7 @@ def self.available_options
           FastlaneCore::ConfigItem.new(key: :skip_confirm,
                                        env_name: 'FL_ANDROID_COMPLETECODEFREEZE_PRECHECKS_SKIPCONFIRM',
                                        description: 'Skips confirmation',
-                                       is_string: false, # true: verifies the input is a string, false: every kind of value
+                                       type: Boolean,
                                        default_value: false), # the default value if the user didn't provide one
         ]
       end
diff --git a/lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_download_translations_action.rb b/lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_download_translations_action.rb
@@ -91,7 +91,7 @@ def self.available_options
             key: :skip_commit,
             env_name: 'FL_DOWNLOAD_TRANSLATIONS_SKIP_COMMIT',
             description: 'If set to true, will skip the commit/push step. Otherwise, it will commit the changes and push them (the default)',
-            is_string: false, # Boolean
+            type: Boolean,
             default_value: false
           ),
         ]
diff --git a/lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_finalize_prechecks.rb b/lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_finalize_prechecks.rb
@@ -47,7 +47,7 @@ def self.available_options
           FastlaneCore::ConfigItem.new(key: :skip_confirm,
                                        env_name: 'FL_ANDROID_FINALIZE_PRECHECKS_SKIPCONFIRM',
                                        description: 'Skips confirmation',
-                                       is_string: false, # true: verifies the input is a string, false: every kind of value
+                                       type: Boolean,
                                        default_value: false), # the default value if the user didn't provide one
         ]
       end
diff --git a/lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_hotfix_prechecks.rb b/lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_hotfix_prechecks.rb
@@ -55,7 +55,7 @@ def self.available_options
           FastlaneCore::ConfigItem.new(key: :skip_confirm,
                                        env_name: 'FL_ANDROID_HOTFIX_PRECHECKS_SKIPCONFIRM',
                                        description: 'Skips confirmation',
-                                       is_string: false, # Boolean
+                                       type: Boolean,
                                        default_value: false),
         ]
       end
diff --git a/lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_tag_build.rb b/lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_tag_build.rb
@@ -28,7 +28,7 @@ def self.available_options
           FastlaneCore::ConfigItem.new(key: :tag_alpha,
                                        env_name: 'FL_ANDROID_TAG_BUILD_ALPHA',
                                        description: 'True to skip tagging the alpha version',
-                                       is_string: false,
+                                       type: Boolean,
                                        default_value: true),
         ]
       end
diff --git a/lib/fastlane/plugin/wpmreleasetoolkit/actions/common/check_for_toolkit_updates_action.rb b/lib/fastlane/plugin/wpmreleasetoolkit/actions/common/check_for_toolkit_updates_action.rb
@@ -86,7 +86,7 @@ def self.available_options
           FastlaneCore::ConfigItem.new(key: :skip_update_suggestion,
                                        env_name: 'CHECK_FOR_TOOLKIT_UPDATES_SKIP_UPDATE_SUGGESTION',
                                        description: 'If true, will still check for new versions, but will not ask if you want to run bundle update if an update is found',
-                                       is_string: false, # Boolean
+                                       type: Boolean,
                                        default_value: false),
         ]
       end
diff --git a/lib/fastlane/plugin/wpmreleasetoolkit/actions/common/check_translation_progress.rb b/lib/fastlane/plugin/wpmreleasetoolkit/actions/common/check_translation_progress.rb
@@ -125,13 +125,13 @@ def self.available_options
                                        description: 'Should we abort with a global error if any violations are found?',
                                        optional: true,
                                        default_value: true,
-                                       is_string: false),
+                                       type: Boolean),
           FastlaneCore::ConfigItem.new(key: :skip_confirm,
                                        env_name: 'FL_CHECK_TRANSLATION_SKIP_CONFIRM',
                                        description: 'Move ahead without requesting confirmation if violations are found. Only works if "abort_on_violations" is disabled',
                                        optional: true,
                                        default_value: false,
-                                       is_string: false),
+                                       type: Boolean),
         ]
       end
 
diff --git a/lib/fastlane/plugin/wpmreleasetoolkit/actions/common/create_release_action.rb b/lib/fastlane/plugin/wpmreleasetoolkit/actions/common/create_release_action.rb
@@ -84,7 +84,7 @@ def self.available_options
                                        description: 'True if this is a pre-release',
                                        optional: true,
                                        default_value: false,
-                                       is_string: false),
+                                       type: Boolean),
           FastlaneCore::ConfigItem.new(key: :is_draft,
                                        env_name: 'GHHELPER_CREATE_RELEASE_IS_DRAFT',
                                        description: 'True to create the GitHub release as a draft (instead of publishing it immediately)',
diff --git a/lib/fastlane/plugin/wpmreleasetoolkit/actions/common/gp_downloadmetadata_action.rb b/lib/fastlane/plugin/wpmreleasetoolkit/actions/common/gp_downloadmetadata_action.rb
@@ -67,7 +67,7 @@ def self.available_options
           FastlaneCore::ConfigItem.new(key: :download_path,
                                        env_name: 'FL_DOWNLOAD_METADATA_DOWNLOAD_PATH',
                                        description: 'The path of the target files',
-                                       is_string: true),
+                                       type: String),
         ]
       end
 
diff --git a/lib/fastlane/plugin/wpmreleasetoolkit/actions/configure/configure_apply_action.rb b/lib/fastlane/plugin/wpmreleasetoolkit/actions/configure/configure_apply_action.rb
@@ -127,7 +127,7 @@ def self.available_options
                                        description: 'Overwrite copied files without confirmation',
                                        optional: true,
                                        default_value: false,
-                                       is_string: false),
+                                       type: Boolean),
         ]
       end
 
diff --git a/lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_betabuild_prechecks.rb b/lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_betabuild_prechecks.rb
@@ -64,11 +64,11 @@ def self.available_options
                                        env_name: 'FL_IOS_BETABUILD_PRECHECKS_BASE_VERSION',
                                        description: 'The version to work on', # a short description of this parameter
                                        type: String,
-                                       optional: true), # true: verifies the input is a string, false: every kind of value),
+                                       optional: true),
           FastlaneCore::ConfigItem.new(key: :skip_confirm,
                                        env_name: 'FL_IOS_BETABUILD_PRECHECKS_SKIPCONFIRM',
                                        description: 'Skips confirmation',
-                                       is_string: false, # true: verifies the input is a string, false: every kind of value
+                                       type: Boolean,
                                        default_value: false), # the default value if the user didn't provide one
           FastlaneCore::ConfigItem.new(key: :default_branch,
                                        env_name: 'FL_RELEASE_TOOLKIT_DEFAULT_BRANCH',
diff --git a/lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_build_prechecks.rb b/lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_build_prechecks.rb
@@ -36,22 +36,22 @@ def self.available_options
           FastlaneCore::ConfigItem.new(key: :skip_confirm,
                                        env_name: 'FL_IOS_BUILD_PRECHECKS_SKIP_CONFIRM',
                                        description: 'True to avoid the system ask for confirmation',
-                                       is_string: false,
+                                       type: Boolean,
                                        default_value: false),
           FastlaneCore::ConfigItem.new(key: :internal,
                                        env_name: 'FL_IOS_BUILD_PRECHECKS_INTERNAL_BUILD',
                                        description: 'True if this is for an internal build',
-                                       is_string: false,
+                                       type: Boolean,
                                        default_value: false),
           FastlaneCore::ConfigItem.new(key: :external,
                                        env_name: 'FL_IOS_BUILD_PRECHECKS_EXTERNAL_BUILD',
                                        description: 'True if this is for a public build',
-                                       is_string: false,
+                                       type: Boolean,
                                        default_value: false),
           FastlaneCore::ConfigItem.new(key: :internal_on_single_version,
                                        env_name: 'FL_IOS_BUILD_PRECHECKS_INTERNAL_SV_BUILD',
                                        description: 'True if this is for an internal build that follows the same versioning of the external',
-                                       is_string: false,
+                                       type: Boolean,
                                        default_value: false),
         ]
       end
diff --git a/lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_bump_version_hotfix.rb b/lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_bump_version_hotfix.rb
@@ -55,7 +55,7 @@ def self.available_options
             key: :skip_deliver,
             env_name: 'FL_IOS_BUMP_VERSION_HOTFIX_SKIP_DELIVER',
             description: 'Skips Deliverfile key update',
-            is_string: false, # Boolean parameter
+            type: Boolean,
             optional: true,
             # Don't skip the Deliverfile by default. At the time of writing, 2 out of 3 consumers
             # still have a Deliverfile.
diff --git a/lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_codefreeze_prechecks.rb b/lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_codefreeze_prechecks.rb
@@ -47,7 +47,7 @@ def self.available_options
           FastlaneCore::ConfigItem.new(key: :skip_confirm,
                                        env_name: 'FL_IOS_CODEFREEZE_PRECHECKS_SKIPCONFIRM',
                                        description: 'Skips confirmation before codefreeze',
-                                       is_string: false, # true: verifies the input is a string, false: every kind of value
+                                       type: Boolean,
                                        default_value: false), # the default value if the user didn't provide one
           FastlaneCore::ConfigItem.new(key: :default_branch,
                                        env_name: 'FL_RELEASE_TOOLKIT_DEFAULT_BRANCH',
diff --git a/lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_completecodefreeze_prechecks.rb b/lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_completecodefreeze_prechecks.rb
@@ -40,7 +40,7 @@ def self.available_options
           FastlaneCore::ConfigItem.new(key: :skip_confirm,
                                        env_name: 'FL_IOS_COMPLETECODEFREEZE_PRECHECKS_SKIPCONFIRM',
                                        description: 'Skips confirmation',
-                                       is_string: false, # true: verifies the input is a string, false: every kind of value
+                                       type: Boolean,
                                        default_value: false), # the default value if the user didn't provide one
         ]
       end
diff --git a/lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_finalize_prechecks.rb b/lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_finalize_prechecks.rb
@@ -40,7 +40,7 @@ def self.available_options
           FastlaneCore::ConfigItem.new(key: :skip_confirm,
                                        env_name: 'FL_IOS_FINALIZE_PRECHECKS_SKIPCONFIRM',
                                        description: 'Skips confirmation',
-                                       is_string: false, # true: verifies the input is a string, false: every kind of value
+                                       type: Boolean,
                                        default_value: false), # the default value if the user didn't provide one
         ]
       end
diff --git a/lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_generate_strings_file_from_code.rb b/lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_generate_strings_file_from_code.rb
@@ -74,12 +74,12 @@ def self.available_options
           FastlaneCore::ConfigItem.new(key: :quiet,
                                        env_name: 'FL_IOS_GENERATE_STRINGS_FILE_FROM_CODE_QUIET',
                                        description: 'In quiet mode, `genstrings` will log warnings about duplicate values, but not about duplicate comments',
-                                       is_string: false, # Boolean
+                                       type: Boolean,
                                        default_value: true),
           FastlaneCore::ConfigItem.new(key: :swiftui,
                                        env_name: 'FL_IOS_GENERATE_STRINGS_FILE_FROM_CODE_SWIFTUI',
                                        description: "Should we include SwiftUI's `Text()` when parsing code with `genstrings`",
-                                       is_string: false, # Boolean
+                                       type: Boolean,
                                        default_value: false),
           FastlaneCore::ConfigItem.new(key: :output_dir,
                                        env_name: 'FL_IOS_GENERATE_STRINGS_FILE_FROM_CODE_OUTPUT_DIR',
@@ -88,7 +88,7 @@ def self.available_options
           FastlaneCore::ConfigItem.new(key: :fail_on_error,
                                        env_name: 'FL_IOS_GENERATE_STRINGS_FILE_FROM_CODE_FAIL_ON_ERROR',
                                        description: 'If true, will fail with user_error! if `genstrings` printed any error while parsing',
-                                       is_string: false, # Boolean
+                                       type: Boolean,
                                        default_value: true),
         ]
       end
diff --git a/lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_get_build_version.rb b/lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_get_build_version.rb
@@ -32,7 +32,7 @@ def self.available_options
             key: :internal,
             env_name: 'FL_IOS_BUILD_VERSION_INTERNAL',
             description: 'If true, returns the internal build version, otherwise returns the public one',
-            is_string: false, # Boolean
+            type: Boolean,
             default_value: false
           ),
         ]
diff --git a/lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_hotfix_prechecks.rb b/lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_hotfix_prechecks.rb
@@ -55,7 +55,7 @@ def self.available_options
           FastlaneCore::ConfigItem.new(key: :skip_confirm,
                                        env_name: 'FL_IOS_HOTFIX_PRECHECKS_SKIPCONFIRM',
                                        description: 'Skips confirmation',
-                                       is_string: false, # true: verifies the input is a string, false: every kind of value
+                                       type: Boolean,
                                        default_value: false), # the default value if the user didn't provide one
         ]
       end
diff --git a/lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_lint_localizations.rb b/lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_lint_localizations.rb
@@ -163,23 +163,23 @@ def self.available_options
             description: 'Should we abort the rest of the lane with a global error if any violations are found?',
             optional: true,
             default_value: true,
-            is_string: false # https://docs.fastlane.tools/advanced/actions/#boolean-parameters
+            type: Boolean
           ),
           FastlaneCore::ConfigItem.new(
             key: :allow_retry,
             env_name: 'FL_IOS_LINT_TRANSLATIONS_ALLOW_RETRY',
             description: 'If any violations are found, show an interactive prompt allowing the user to manually fix the issues locally and retry the linting',
             optional: true,
             default_value: false,
-            is_string: false # https://docs.fastlane.tools/advanced/actions/#boolean-parameters
+            type: Boolean
           ),
           FastlaneCore::ConfigItem.new(
             key: :check_duplicate_keys,
             env_name: 'FL_IOS_LINT_TRANSLATIONS_CHECK_DUPLICATE_KEYS',
             description: 'Checks the input files for duplicate keys',
             optional: true,
             default_value: true,
-            is_string: false # https://docs.fastlane.tools/advanced/actions/#boolean-parameters
+            type: Boolean
           ),
         ]
       end

Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ def self.available_options`
`40`	`40`	`FastlaneCore::ConfigItem.new(key: :skip_confirm,`
`41`	`41`	`env_name: 'FL_ANDROID_COMPLETECODEFREEZE_PRECHECKS_SKIPCONFIRM',`
`42`	`42`	`description: 'Skips confirmation',`
`43`		`- is_string: false, # true: verifies the input is a string, false: every kind of value`
	`43`	`+ type: Boolean,`
`44`	`44`	`default_value: false), # the default value if the user didn't provide one`
`45`	`45`	`]`
`46`	`46`	`end`
Original file line number	Diff line number	Diff line change
`@@ -91,7 +91,7 @@ def self.available_options`
`91`	`91`	`key: :skip_commit,`
`92`	`92`	`env_name: 'FL_DOWNLOAD_TRANSLATIONS_SKIP_COMMIT',`
`93`	`93`	`description: 'If set to true, will skip the commit/push step. Otherwise, it will commit the changes and push them (the default)',`
`94`		`- is_string: false, # Boolean`
	`94`	`+ type: Boolean,`
`95`	`95`	`default_value: false`
`96`	`96`	`),`
`97`	`97`	`]`
Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,7 @@ def self.available_options`
`47`	`47`	`FastlaneCore::ConfigItem.new(key: :skip_confirm,`
`48`	`48`	`env_name: 'FL_ANDROID_FINALIZE_PRECHECKS_SKIPCONFIRM',`
`49`	`49`	`description: 'Skips confirmation',`
`50`		`- is_string: false, # true: verifies the input is a string, false: every kind of value`
	`50`	`+ type: Boolean,`
`51`	`51`	`default_value: false), # the default value if the user didn't provide one`
`52`	`52`	`]`
`53`	`53`	`end`
Original file line number	Diff line number	Diff line change
`@@ -55,7 +55,7 @@ def self.available_options`
`55`	`55`	`FastlaneCore::ConfigItem.new(key: :skip_confirm,`
`56`	`56`	`env_name: 'FL_ANDROID_HOTFIX_PRECHECKS_SKIPCONFIRM',`
`57`	`57`	`description: 'Skips confirmation',`
`58`		`- is_string: false, # Boolean`
	`58`	`+ type: Boolean,`
`59`	`59`	`default_value: false),`
`60`	`60`	`]`
`61`	`61`	`end`
Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@ def self.available_options`
`28`	`28`	`FastlaneCore::ConfigItem.new(key: :tag_alpha,`
`29`	`29`	`env_name: 'FL_ANDROID_TAG_BUILD_ALPHA',`
`30`	`30`	`description: 'True to skip tagging the alpha version',`
`31`		`- is_string: false,`
	`31`	`+ type: Boolean,`
`32`	`32`	`default_value: true),`
`33`	`33`	`]`
`34`	`34`	`end`
Original file line number	Diff line number	Diff line change
`@@ -86,7 +86,7 @@ def self.available_options`
`86`	`86`	`FastlaneCore::ConfigItem.new(key: :skip_update_suggestion,`
`87`	`87`	`env_name: 'CHECK_FOR_TOOLKIT_UPDATES_SKIP_UPDATE_SUGGESTION',`
`88`	`88`	`description: 'If true, will still check for new versions, but will not ask if you want to run bundle update if an update is found',`
`89`		`- is_string: false, # Boolean`
	`89`	`+ type: Boolean,`
`90`	`90`	`default_value: false),`
`91`	`91`	`]`
`92`	`92`	`end`