Skip to content

Commit e5550b6

Browse files
Convert all instances of is_string: true to type: String
1 parent e4b28a4 commit e5550b6

21 files changed

+30
-30
lines changed

lib/fastlane/plugin/wpmreleasetoolkit/actions/android/an_update_metadata_source_action.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ def self.available_options
131131
FastlaneCore::ConfigItem.new(key: :po_file_path,
132132
env_name: 'FL_UPDATE_METADATA_SOURCE_PO_FILE_PATH',
133133
description: 'The path of the .po file to update',
134-
is_string: true,
134+
type: String,
135135
verify_block: proc do |value|
136136
UI.user_error!("No .po file path for UpdateMetadataSourceAction given, pass using `po_file_path: 'file path'`") unless value && (!value.empty?)
137137
UI.user_error!("Couldn't find file at path '#{value}'") unless File.exist?(value)

lib/fastlane/plugin/wpmreleasetoolkit/actions/android/an_validate_lib_strings_action.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ def self.available_options
4141
FastlaneCore::ConfigItem.new(key: :app_strings_path,
4242
description: 'The path of the main strings file',
4343
optional: false,
44-
is_string: true),
44+
type: String),
4545
FastlaneCore::ConfigItem.new(key: :libs_strings_path,
4646
env_name: 'CHECK_LIBS_STRINGS_PATH',
4747
description: 'The list of libs to merge',
@@ -51,7 +51,7 @@ def self.available_options
5151
env_name: 'CHECK_LIBS_DIFF_URL',
5252
description: 'The url of the diff to check',
5353
optional: true,
54-
is_string: true),
54+
type: String),
5555
]
5656
end
5757

lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_betabuild_prechecks.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ def self.available_options
7474
FastlaneCore::ConfigItem.new(key: :base_version,
7575
env_name: 'FL_ANDROID_BETABUILD_PRECHECKS_BASE_VERSION',
7676
description: 'The version to work on', # a short description of this parameter
77-
is_string: true,
77+
type: String,
7878
optional: true), # true: verifies the input is a string, false: every kind of value),
7979
FastlaneCore::ConfigItem.new(key: :skip_confirm,
8080
env_name: 'FL_ANDROID_BETABUILD_PRECHECKS_SKIPCONFIRM',

lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_bump_version_hotfix.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,14 +43,14 @@ def self.available_options
4343
FastlaneCore::ConfigItem.new(key: :version_name,
4444
env_name: 'FL_ANDROID_BUMP_VERSION_HOTFIX_VERSION',
4545
description: 'The version name for the hotfix',
46-
is_string: true),
46+
type: String),
4747
FastlaneCore::ConfigItem.new(key: :version_code,
4848
env_name: 'FL_ANDROID_BUMP_VERSION_HOTFIX_CODE',
4949
description: 'The version code for the hotfix'),
5050
FastlaneCore::ConfigItem.new(key: :previous_version_name,
5151
env_name: 'FL_ANDROID_BUMP_VERSION_HOTFIX_PREVIOUS_VERSION',
5252
description: 'The version to branch from',
53-
is_string: true),
53+
type: String),
5454
]
5555
end
5656

lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_create_xml_release_notes.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,12 +38,12 @@ def self.available_options
3838
env_name: 'ANDROID_XML_NOTES_DOWNLOAD_PATH',
3939
description: 'The path to the folder with the release notes',
4040
optional: false,
41-
is_string: true),
41+
type: String),
4242
FastlaneCore::ConfigItem.new(key: :build_number,
4343
env_name: 'ANDROID_XML_NOTES_BUILD_NUMBER',
4444
description: 'The build number of the release notes',
4545
optional: false,
46-
is_string: true),
46+
type: String),
4747
FastlaneCore::ConfigItem.new(key: :locales,
4848
env_name: 'FL_DOWNLOAD_METADATA_LOCALES',
4949
description: 'The hash with the GLotPress locale and the project locale association',

lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_hotfix_prechecks.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ def self.available_options
5151
FastlaneCore::ConfigItem.new(key: :version_name,
5252
env_name: 'FL_ANDROID_HOTFIX_PRECHECKS_VERSION',
5353
description: 'The hotfix version number to create',
54-
is_string: true),
54+
type: String),
5555
FastlaneCore::ConfigItem.new(key: :skip_confirm,
5656
env_name: 'FL_ANDROID_HOTFIX_PRECHECKS_SKIPCONFIRM',
5757
description: 'Skips confirmation',

lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_update_release_notes.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,11 +34,11 @@ def self.available_options
3434
FastlaneCore::ConfigItem.new(key: :new_version,
3535
env_name: 'FL_ANDROID_UPDATE_RELEASE_NOTES_VERSION',
3636
description: 'The version we are currently freezing; An empty entry for the _next_ version after this one will be added to the release notes',
37-
is_string: true),
37+
type: String),
3838
FastlaneCore::ConfigItem.new(key: :release_notes_file_path,
3939
env_name: 'FL_ANDROID_UPDATE_RELEASE_NOTES_FILE_PATH',
4040
description: 'The path to the release notes file to be updated',
41-
is_string: true,
41+
type: String,
4242
default_value: File.join(ENV['PROJECT_ROOT_FOLDER'] || '.', 'RELEASE-NOTES.txt')),
4343
]
4444
end

lib/fastlane/plugin/wpmreleasetoolkit/actions/common/extract_release_notes_for_version_action.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -67,17 +67,17 @@ def self.available_options
6767
env_name: 'GHHELPER_EXTRACT_NOTES_VERSION',
6868
description: 'The version of the release',
6969
optional: false,
70-
is_string: true),
70+
type: String),
7171
FastlaneCore::ConfigItem.new(key: :release_notes_file_path,
7272
env_name: 'GHHELPER_EXTRACT_NOTES_FILE_PATH',
7373
description: 'The path to the file that contains the release notes',
7474
optional: false,
75-
is_string: true),
75+
type: String),
7676
FastlaneCore::ConfigItem.new(key: :extracted_notes_file_path,
7777
env_name: 'GHHELPER_EXTRACT_NOTES_EXTRACTED_FILE_PATH',
7878
description: 'The path to the file that will contain the extracted release notes',
7979
optional: true,
80-
is_string: true),
80+
type: String),
8181
]
8282
end
8383

lib/fastlane/plugin/wpmreleasetoolkit/actions/common/get_prs_list_action.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,11 +49,11 @@ def self.available_options
4949
FastlaneCore::ConfigItem.new(key: :report_path,
5050
description: 'The path where the list of PRs should be written to',
5151
optional: false,
52-
is_string: true),
52+
type: String),
5353
FastlaneCore::ConfigItem.new(key: :milestone,
5454
description: 'The name of the milestone we want to fetch the list of PRs for (e.g.: `16.9`)',
5555
optional: false,
56-
is_string: true),
56+
type: String),
5757
Fastlane::Helper::GithubHelper.github_token_config_item,
5858
]
5959
end

lib/fastlane/plugin/wpmreleasetoolkit/actions/common/gp_update_metadata_source.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ def self.available_options
130130
FastlaneCore::ConfigItem.new(key: :po_file_path,
131131
env_name: 'FL_UPDATE_METADATA_SOURCE_PO_FILE_PATH',
132132
description: 'The path of the .po file to update',
133-
is_string: true,
133+
type: String,
134134
verify_block: proc do |value|
135135
UI.user_error!("No .po file path for UpdateMetadataSourceAction given, pass using `po_file_path: 'file path'`") unless value && (!value.empty?)
136136
UI.user_error!("Couldn't find file at path '#{value}'") unless File.exist?(value)

0 commit comments

Comments
 (0)