Fix Style/ZeroLengthPredicate violations

Author: spencertransier

.rubocop_todo.yml

@@ -319,12 +319,3 @@ Style/SymbolProc:
     - 'lib/fastlane/plugin/wpmreleasetoolkit/helper/configure_helper.rb'
     - 'lib/fastlane/plugin/wpmreleasetoolkit/helper/ios/ios_version_helper.rb'
     - 'lib/fastlane/plugin/wpmreleasetoolkit/models/configuration.rb'
-
-# Offense count: 4
-# This cop supports unsafe autocorrection (--autocorrect-all).
-Style/ZeroLengthPredicate:
-  Exclude:
-    - 'lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/add_development_certificates_to_provisioning_profiles.rb'
-    - 'lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/add_devices_to_provisioning_profiles.rb'
-    - 'lib/fastlane/plugin/wpmreleasetoolkit/helper/git_helper.rb'
-    - 'lib/fastlane/plugin/wpmreleasetoolkit/helper/metadata_download_helper.rb'

lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/add_development_certificates_to_provisioning_profiles.rb

@@ -17,7 +17,7 @@ def self.run(params)
             profile.is_a? Spaceship::Portal::ProvisioningProfile::Development
           end
                    .tap do |profiles|
-            UI.important "Warning: Unable to find any profiles associated with #{identifier}" unless profiles.length > 0
+            UI.important "Warning: Unable to find any profiles associated with #{identifier}" if profiles.empty?
           end
                    .each do |profile|
             profile.certificates = all_certificates

lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/add_devices_to_provisioning_profiles.rb

@@ -15,7 +15,7 @@ def self.run(params)
             profile.is_a? Spaceship::Portal::ProvisioningProfile::Development
           end
                    .tap do |profiles|
-            UI.important "Warning: Unable to find any profiles associated with #{identifier}" unless profiles.length > 0
+            UI.important "Warning: Unable to find any profiles associated with #{identifier}" if profiles.empty?
           end
                    .each do |profile|
             profile.devices = devices

lib/fastlane/plugin/wpmreleasetoolkit/helper/git_helper.rb

@@ -47,7 +47,7 @@ def self.first_existing_ancestor_of(path:)
       def self.has_git_lfs?
         return false unless is_git_repo?
 
-        `git config --get-regex lfs`.length > 0
+        !`git config --get-regex lfs`.empty?
       end
 
       # Switch to the given branch and pull its latest commits.

lib/fastlane/plugin/wpmreleasetoolkit/helper/metadata_download_helper.rb

@@ -111,7 +111,7 @@ def handle_glotpress_download(response:, locale:, is_source:)
           @alternates.clear
           loc_data = JSON.parse(response.body) rescue loc_data = nil
           parse_data(locale, loc_data, is_source)
-          reparse_alternates(target_locale, loc_data, is_source) unless @alternates.length == 0
+          reparse_alternates(target_locale, loc_data, is_source) unless @alternates.empty?
         when '301'
           # Follow the redirect
           UI.message("Received 301 for `#{locale}`. Following redirect...")