Fix Style/UnlessElse violations

Author: spencertransier

.rubocop_todo.yml

@@ -320,14 +320,6 @@ Style/SymbolProc:
     - 'lib/fastlane/plugin/wpmreleasetoolkit/helper/ios/ios_version_helper.rb'
     - 'lib/fastlane/plugin/wpmreleasetoolkit/models/configuration.rb'
 
-# Offense count: 3
-# This cop supports safe autocorrection (--autocorrect).
-Style/UnlessElse:
-  Exclude:
-    - 'lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_completecodefreeze_prechecks.rb'
-    - 'lib/fastlane/plugin/wpmreleasetoolkit/actions/common/promo_screenshots_action.rb'
-    - 'lib/fastlane/plugin/wpmreleasetoolkit/actions/configure/configure_download_action.rb'
-
 # Offense count: 4
 # This cop supports unsafe autocorrection (--autocorrect-all).
 Style/ZeroLengthPredicate:

lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_completecodefreeze_prechecks.rb

@@ -13,10 +13,10 @@ def self.run(params)
 
         version = Fastlane::Helper::Android::VersionHelper.get_public_version
         message = "Completing code freeze for: #{version}\n"
-        unless params[:skip_confirm]
-          UI.user_error!('Aborted by user request') unless UI.confirm("#{message}Do you want to continue?")
-        else
+        if params[:skip_confirm]
           UI.message(message)
+        else
+          UI.user_error!('Aborted by user request') unless UI.confirm("#{message}Do you want to continue?")
         end
 
         # Check local repo status

lib/fastlane/plugin/wpmreleasetoolkit/actions/common/promo_screenshots_action.rb

@@ -18,11 +18,11 @@ def self.run(params)
         translationDirectories = subdirectories_for_path(params[:metadata_folder])
         imageDirectories = subdirectories_for_path(params[:orig_folder])
 
-        unless helper.can_resolve_path(params[:output_folder])
+        if helper.can_resolve_path(params[:output_folder])
+          UI.message "#{self.check_path(params[:output_folder])} Output Folder: #{params[:output_folder]}"
+        else
           UI.message "✅ Created Output Folder: #{params[:output_folder]}"
           FileUtils.mkdir_p(params[:output_folder])
-        else
-          UI.message "#{self.check_path(params[:output_folder])} Output Folder: #{params[:output_folder]}"
         end
 
         outputDirectory = helper.resolve_path(params[:output_folder])

lib/fastlane/plugin/wpmreleasetoolkit/actions/configure/configure_download_action.rb

@@ -9,10 +9,10 @@ def self.run(params = {})
         UI.message 'Running Configure Download'
 
         # If the `~/.mobile-secrets` repository doesn't exist
-        unless File.directory?(secrets_dir)
-          UI.user_error!("The local secrets store does not exist. Please clone it to #{secrets_dir} before continuing.")
-        else
+        if File.directory?(secrets_dir)
           update_repository # If the repo already exists, just update it
+        else
+          UI.user_error!("The local secrets store does not exist. Please clone it to #{secrets_dir} before continuing.")
         end
       end