Skip to content

Exclude deleted sites from getBlogs #833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 19, 2025

Conversation

crazytonyli
Copy link
Contributor

@crazytonyli crazytonyli commented Mar 18, 2025

Description

WordPressKit.zip

Relates to wordpress-mobile/WordPress-iOS#23344.

We'll exclude deleted sites for now, and can add them back once the app supports them properly.

ℹ Please replace the above with a link to the issue this pull request addresses, as well as a summary of the implementation details.

Testing Details

ℹ Please replace this with a clear and concise description of the steps required to validate this pull request.


  • Please check here if your pull request includes additional test coverage.
  • I have considered if this change warrants release notes and have added them to the appropriate section in the CHANGELOG.md if necessary.

@crazytonyli crazytonyli changed the base branch from trunk to wpios-edition March 18, 2025 01:14
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ Package.swift was changed without updating its corresponding Package.resolved. Please resolve the Swift packages in Xcode.

Generated by 🚫 Danger

@crazytonyli crazytonyli force-pushed the me-sites-exclude-deleted branch 2 times, most recently from bc9b11c to 5b504d0 Compare March 18, 2025 01:45
@crazytonyli crazytonyli force-pushed the me-sites-exclude-deleted branch from 5b504d0 to baf2f40 Compare March 18, 2025 09:32
@crazytonyli crazytonyli changed the title Me sites exclude deleted Exclude deleted sites from getBlogs Mar 18, 2025
@crazytonyli crazytonyli requested review from kean and pmusolino March 18, 2025 09:34
@crazytonyli crazytonyli marked this pull request as ready for review March 18, 2025 09:34
@pmusolino pmusolino self-assigned this Mar 18, 2025
Copy link
Contributor

@pmusolino pmusolino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! :shipit:

@crazytonyli crazytonyli merged commit 554d3ef into wpios-edition Mar 19, 2025
9 checks passed
@crazytonyli crazytonyli deleted the me-sites-exclude-deleted branch March 19, 2025 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants