Skip to content

Support editing media metadata via XMLRPC #809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

staskus
Copy link
Contributor

@staskus staskus commented Jun 5, 2024

Description

Related ticket: wordpress-mobile/WordPress-iOS#20726

Media is a type of post therefore "wp.editPost" can be used to edit media metadata via XML-RPC.

Note that alternative text cannot be edited due to lack of XML-RPC support https://core.trac.wordpress.org/ticket/58582. Explanation: wordpress-mobile/WordPress-Android#18514 (comment)

Android solution: https://github.com/wordpress-mobile/WordPress-FluxC-Android/blob/98d43f5f4ed25dbacac85fc42889a6ac529c03e4/fluxc/src/main/java/org/wordpress/android/fluxc/network/xmlrpc/media/MediaXMLRPCClient.java#L99

ℹ Please replace the above with a link to the issue this pull request addresses, as well as a summary of the implementation details.

Testing Details

ℹ Please replace this with a clear and concise description of the steps required to validate this pull request.


  • Please check here if your pull request includes additional test coverage.
  • I have considered if this change warrants release notes and have added them to the appropriate section in the CHANGELOG.md if necessary.

staskus added 2 commits June 5, 2024 16:56
Media is a type of a post therefore "wp.editPost" can be used to edit media metadata. Note that alternative text cannot be edited due to lack of XML-RPC support https://core.trac.wordpress.org/ticket/58582
@staskus staskus marked this pull request as ready for review June 6, 2024 05:45
@staskus staskus added the enhancement New feature or request label Jun 6, 2024
@staskus staskus requested a review from guarani June 6, 2024 06:05
@crazytonyli
Copy link
Contributor

I'm in the process of copying this repo's source code into WordPress-iOS. We'll make WordPress/Jetpack app specific changes within the app repo instead. Do you mind holding off merging this PR and opening a new one in the app repo, once wordpress-mobile/WordPress-iOS#23366 is merged?

@staskus
Copy link
Contributor Author

staskus commented Jun 18, 2024

Yes, all good @crazytonyli 👍

@marijn390
Copy link

@staskus Any idea when this will be fixed? I reported this a year ago and it was already known to WP. It is very frustrating that this does not work and that I have to use the Jetpack plugin specifically for this, then it does work.

@staskus
Copy link
Contributor Author

staskus commented Jun 20, 2024

@staskus Any idea when this will be fixed? I reported this a year ago and it was already known to WP. It is very frustrating that this does not work and that I have to use the Jetpack plugin specifically for this, and then it does work.

@marijn390, we're in the process of code review for the fix. Should be merged and included into the app soon!

@marijn390
Copy link

marijn390 commented Jun 20, 2024 via email

@staskus
Copy link
Contributor Author

staskus commented Jun 20, 2024

@marijn390, I'll check more on the background of this issue. However, currently, we use the same approach on Android and it works, albeit imperfectly. For example, alt text is not supported via XMLRPC.

@staskus
Copy link
Contributor Author

staskus commented Jun 21, 2024

Solution moved to wordpress-mobile/WordPress-iOS#23316

@staskus staskus closed this Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants