-
Notifications
You must be signed in to change notification settings - Fork 16
Support editing media metadata via XMLRPC #809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support editing media metadata via XMLRPC #809
Conversation
Media is a type of a post therefore "wp.editPost" can be used to edit media metadata. Note that alternative text cannot be edited due to lack of XML-RPC support https://core.trac.wordpress.org/ticket/58582
I'm in the process of copying this repo's source code into WordPress-iOS. We'll make WordPress/Jetpack app specific changes within the app repo instead. Do you mind holding off merging this PR and opening a new one in the app repo, once wordpress-mobile/WordPress-iOS#23366 is merged? |
Yes, all good @crazytonyli 👍 |
@staskus Any idea when this will be fixed? I reported this a year ago and it was already known to WP. It is very frustrating that this does not work and that I have to use the Jetpack plugin specifically for this, then it does work. |
@marijn390, we're in the process of code review for the fix. Should be merged and included into the app soon! |
@staskus, That's great! Someone from the WP mobile app team told me a year ago that it could take a very long time because this would only work when the REST API would be fully active. XMLRPC would not support metadata for images and everything would be over REST API. Have plans changed why you are now enabling this via the old and insecure XMLRPC protocol?
…________________________________
Van: Povilas Staskus ***@***.***>
Verzonden: donderdag, juni 20, 2024 11:45 AM
Aan: wordpress-mobile/WordPressKit-iOS ***@***.***>
CC: marijn390 ***@***.***>; Mention ***@***.***>
Onderwerp: Re: [wordpress-mobile/WordPressKit-iOS] Support editing media metadata via XMLRPC (PR #809)
@staskus<https://github.com/staskus> Any idea when this will be fixed? I reported this a year ago and it was already known to WP. It is very frustrating that this does not work and that I have to use the Jetpack plugin specifically for this, and then it does work.
@marijn390<https://github.com/marijn390>, we're in the process of code review for the fix. Should be merged and included into the app soon!
—
Reply to this email directly, view it on GitHub<#809 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BASQTMVSMYJZTFQWMVL75KTZIKQDXAVCNFSM6AAAAABI2ZFNJCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBQGI3DEMJQHA>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
@marijn390, I'll check more on the background of this issue. However, currently, we use the same approach on Android and it works, albeit imperfectly. For example, alt text is not supported via XMLRPC. |
Solution moved to wordpress-mobile/WordPress-iOS#23316 |
Description
Related ticket: wordpress-mobile/WordPress-iOS#20726
Media is a type of post therefore "wp.editPost" can be used to edit media metadata via XML-RPC.
Note that alternative text cannot be edited due to lack of XML-RPC support https://core.trac.wordpress.org/ticket/58582. Explanation: wordpress-mobile/WordPress-Android#18514 (comment)
Android solution: https://github.com/wordpress-mobile/WordPress-FluxC-Android/blob/98d43f5f4ed25dbacac85fc42889a6ac529c03e4/fluxc/src/main/java/org/wordpress/android/fluxc/network/xmlrpc/media/MediaXMLRPCClient.java#L99
ℹ Please replace the above with a link to the issue this pull request addresses, as well as a summary of the implementation details.
Testing Details
ℹ Please replace this with a clear and concise description of the steps required to validate this pull request.
CHANGELOG.md
if necessary.