Skip to content

Expanded StatsFileDownload entity to contain relativeURL and downloadURL #808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

staskus
Copy link
Contributor

@staskus staskus commented Jun 5, 2024

Description

Expanded StatsFileDownload entity to contain relativeURL and downloadURL

Related to wordpress-mobile/WordPress-iOS#23270

ℹ Please replace the above with a link to the issue this pull request addresses, as well as a summary of the implementation details.

Testing Details

ℹ Please replace this with a clear and concise description of the steps required to validate this pull request.


  • Please check here if your pull request includes additional test coverage.
  • I have considered if this change warrants release notes and have added them to the appropriate section in the CHANGELOG.md if necessary.

@staskus staskus force-pushed the fix/23270-stats-details-supplied-item-identifiers-are-not-unique branch from 800e452 to 9615408 Compare June 5, 2024 10:30
@staskus staskus marked this pull request as ready for review June 5, 2024 10:30
@staskus staskus force-pushed the fix/23270-stats-details-supplied-item-identifiers-are-not-unique branch from 9615408 to 0e3a287 Compare June 5, 2024 10:42
@crazytonyli
Copy link
Contributor

I'm in the process of copying this repo's source code into WordPress-iOS. We'll make WordPress/Jetpack app specific changes within the app repo instead. Do you mind holding off merging this PR and opening a new one in the app repo, once wordpress-mobile/WordPress-iOS#23366 is merged?

@staskus
Copy link
Contributor Author

staskus commented Jun 18, 2024

Yes, all good @crazytonyli 👍

@staskus
Copy link
Contributor Author

staskus commented Jun 21, 2024

Moved to wordpress-mobile/WordPress-iOS#23310

@staskus staskus closed this Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants