Skip to content

Stats: Add stats/emails/summary endpoint support #794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 23, 2024

Conversation

staskus
Copy link
Contributor

@staskus staskus commented Apr 22, 2024

Description

Add support for stats/emails/summary endpoint:

  1. Add StatsEmailsSummaryData entity
  2. Add getData StatsServiceRemoteV2 method for specific StatsEmailsSummaryData result type since its request and response format doesn't match any other current Stats entities
  3. Add tests

Testing Details

wordpress-mobile/WordPress-iOS#23056


  • Please check here if your pull request includes additional test coverage.
  • I have considered if this change warrants release notes and have added them to the appropriate section in the CHANGELOG.md if necessary.

staskus added 3 commits April 21, 2024 22:16
emails/summary doesn't follow existing TimeInterval and Insights patterns therefore I added a separate method
@staskus staskus changed the title Task/emails api endpoint Stats: Add stats/emails/summary endpoint support Apr 22, 2024
Copy link
Contributor

@guarani guarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Tested in wordpress-mobile/WordPress-iOS#23056

@staskus staskus merged commit d95c88b into trunk Apr 23, 2024
9 checks passed
@staskus staskus deleted the task/emails-api-endpoint branch April 23, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants