-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Use TagsView
to manage post tags
#24670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
Generated by 🚫 Danger |
|
App Name | Jetpack | |
Configuration | Release-Alpha | |
Build Number | 28219 | |
Version | PR #24670 | |
Bundle ID | com.jetpack.alpha | |
Commit | 09bf586 | |
Installation URL | 25ane7noicsjg |
|
App Name | WordPress | |
Configuration | Release-Alpha | |
Build Number | 28219 | |
Version | PR #24670 | |
Bundle ID | org.wordpress.alpha | |
Commit | 09bf586 | |
Installation URL | 5rup4tk9h8sig |
Hey, I was planning to rework it in the scope of https://linear.app/a8c/project/post-settings-and-publishing-next-steps-ecf77520ab3c. It's great that you decided to address it, but I think it needs to largely retain the current UX where you enter the tags using a text field that automatically becomes first responder when you open the screen and uses auto-complete to add existing tags. You should also be able to add new tags from this screen by simply adding them to the text field. I think the only option how we could improve the current UX is to add token fields to the text field to make it easier to remove the tags you don't want. |
@kean Oh nice. I didn't notice that project. I started working on this because I'd like to fix this bug on searching tags.
Good catch! I missed adding new tags. Would you like to take this PR over and make it part of the post settings project, or would you prefer me to iterate on this PR? I'm okay either way, just don't want to step on your toes. |
303aae9
to
09bf586
Compare
|
Note
This PR is built on top of #24668.
Description
See the recording below.
add-tags.mp4
Testing instructions