Skip to content

Add more imports required for Keystone to build for testing #24627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 27, 2025
Merged

Add more imports required for Keystone to build for testing #24627

merged 1 commit into from
Jun 27, 2025

Conversation

mokagio
Copy link
Contributor

@mokagio mokagio commented Jun 26, 2025

Similar to #24537

mokagio
mokagio commented Jun 26, 2025
View reviewed changes
WordPress/Classes/ViewRelated/Suggestions/SuggestionsTableView.m
@@ -5,6 +5,9 @@
#else
#import "WordPress-Swift.h"
#endif
// For some reason, the modular import does not work.
// @import WordPressData;
#import <WordPressData/WordPressData.h>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be addressed shortly, in a dedicated PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #24628

@dangermattic
Copy link
Collaborator

dangermattic commented Jun 26, 2025 •
edited
Loading

1 Warning
⚠️ View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.

Generated by 🚫 Danger

@mokagio mokagio requested review from crazytonyli and kean June 26, 2025 05:26
@mokagio mokagio added this to the 26.3 milestone Jun 26, 2025
@mokagio mokagio self-assigned this Jun 26, 2025
@mokagio mokagio added the Tooling Build, Release, and Validation Tools label Jun 26, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@wpmobilebot
Copy link
Contributor

App Icon📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack
ConfigurationRelease-Alpha
Build Number28001
VersionPR #24627
Bundle IDcom.jetpack.alpha
Commit900ef38
Installation URL4tmrn0tivlif0
 Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@wpmobilebot
Copy link
Contributor

App Icon📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress
ConfigurationRelease-Alpha
Build Number28001
VersionPR #24627
Bundle IDorg.wordpress.alpha
Commit900ef38
Installation URL21jia2dj83mc8
 Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@mokagio mokagio added this pull request to the merge queue Jun 27, 2025
Merged via the queue into trunk with commit 6041190 Jun 27, 2025
34 of 36 checks passed
@mokagio mokagio deleted the mokagio/add-some-imports-for-keystone-20250626 branch June 27, 2025 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kean kean kean approved these changes

@crazytonyli crazytonyli Awaiting requested review from crazytonyli

Assignees

@mokagio mokagio

Labels
Tooling Build, Release, and Validation Tools
Projects
None yet
Milestone
26.3
Development

Successfully merging this pull request may close these issues.
4 participants
@mokagio @dangermattic @wpmobilebot @kean