Skip to content

Remove workspace file #24534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 23 commits into
base: trunk
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
40dc57d
Add a dummy local package—We'll try to put the Modules there next
mokagio May 5, 2025
758f862
Replace ModulesAlterantive with Modules
mokagio May 5, 2025
7e2e890
Re-enable all the test targets in WordPressUnitTests
mokagio May 5, 2025
e2465cc
Delete unnecessary OCLint scheme
mokagio May 5, 2025
b17efe1
Configure WordPressFlux scheme to run tests
mokagio May 5, 2025
f6dd3c4
Move Modules package reference from workspace to project
mokagio May 8, 2025
38c0d8a
Use the shared setup CI script in the complete code freeze step
mokagio May 8, 2025
cc744d8
Add workaround for package path support missing
mokagio May 8, 2025
35e360b
Point `color-studio` to a commit instead of a branch
mokagio May 9, 2025
f33347b
WIP - Delete Xcode workspace in favor of project file only
mokagio May 9, 2025
1cfc852
WIP - Fix xcframeworks paths
mokagio May 9, 2025
21e4cd1
WIP - Update paths for build phase scripts
mokagio May 9, 2025
5eaec73
WIP - Update Info.plist path for WordPress
mokagio May 9, 2025
18576e8
WIP - Fix path for SwiftLint aggregate target
mokagio May 9, 2025
5101547
WIP - Fix a bunch more paths
mokagio May 9, 2025
ae1ae18
WIP - Track some new-ly-generated shared schemes
mokagio May 9, 2025
5b36a72
WIP - Fix more paths - Resources
mokagio May 9, 2025
9e5987a
WIP -fix more .. paths
mokagio May 9, 2025
c1f56a5
Fix `INFOPLIST_FILE` definition - Frameworks can't have it
mokagio May 9, 2025
b2c7c51
Convert Sources to a folder reference
mokagio May 9, 2025
218236b
Restore sources for WordPressAuthenticator
mokagio May 9, 2025
e32bca9
Restore header for WordPressData
mokagio May 9, 2025
152cc58
Restore public header for Keystone
mokagio May 9, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions .buildkite/commands/complete-code-freeze.sh
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,7 @@ source use-bot-for-git

.buildkite/commands/checkout-release-branch.sh "$RELEASE_NUMBER"

echo '--- :ruby: Setup Ruby tools'
install_gems

echo "--- :swift: Set up Swift Packages"
install_swiftpm_dependencies
"$(dirname "${BASH_SOURCE[0]}")/shared-set-up.sh"

echo '--- :closed_lock_with_key: Access secrets'
bundle exec fastlane run configure_apply
Expand Down
4 changes: 4 additions & 0 deletions .buildkite/commands/shared-set-up.sh
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,12 @@
echo "--- :rubygems: Setting up Gems"
install_gems

# The push/pop is workaround for tooling not supporting a Package.swift path.
# Note that neither ours nor Apple's tooling does.
pushd "$(dirname "${BASH_SOURCE[0]}")/../../Modules"
echo "--- :swift: Setting up Swift Packages"
install_swiftpm_dependencies
popd

echo "--- :xcode: Fetch XCFrameworks"
rake dependencies
6 changes: 0 additions & 6 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -125,12 +125,6 @@ WordPress/InfoPlist-internal.h
# and assume no local copy would have generated the Pods.
Pods/

# Modules — Where the Swift packages that make up the modular app live
#
# Ignore the Package.resolved file. The packages source of truth is the
# resolved file generated by the Xcode workspace.
Modules/Package.resolved

# While we depend on gutenberg-mobile, we download its XCFrameworks in
# WordPress/Frameworks
WordPress/Frameworks/*.xcframework
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

17 changes: 14 additions & 3 deletions Modules/Package.swift
Original file line number Diff line number Diff line change
Expand Up @@ -48,12 +48,18 @@ let package = Package(
.package(url: "https://github.com/wordpress-mobile/MediaEditor-iOS", branch: "task/spm-support"),
.package(url: "https://github.com/wordpress-mobile/NSObject-SafeExpectations", from: "0.0.6"),
.package(url: "https://github.com/wordpress-mobile/NSURL-IDN", revision: "b34794c9a3f32312e1593d4a3d120572afa0d010"),
.package(url: "https://github.com/wordpress-mobile/WordPressKit-iOS", branch: "wpios-edition"),
.package(
url: "https://github.com/wordpress-mobile/WordPressKit-iOS",
revision: "5bc08764d2025e21685816065f611e884c8672d1" // see wpios-edition branch
),
.package(url: "https://github.com/zendesk/support_sdk_ios", from: "8.0.3"),
// We can't use wordpress-rs branches nor commits here. Only tags work.
.package(url: "https://github.com/Automattic/wordpress-rs", revision: "alpha-20250505"),
.package(url: "https://github.com/wordpress-mobile/GutenbergKit", from: "0.2.0"),
.package(url: "https://github.com/Automattic/color-studio", branch: "trunk"),
.package(
url: "https://github.com/Automattic/color-studio",
revision: "bf141adc75e2769eb469a3e095bdc93dc30be8de"
),
.package(url: "https://github.com/wordpress-mobile/AztecEditor-iOS", from: "1.20.0"),
],
targets: XcodeSupport.targets + [
Expand Down Expand Up @@ -168,7 +174,12 @@ let package = Package(
),
.testTarget(name: "JetpackStatsWidgetsCoreTests", dependencies: [.target(name: "JetpackStatsWidgetsCore")], swiftSettings: [.swiftLanguageMode(.v5)]),
.testTarget(name: "DesignSystemTests", dependencies: [.target(name: "DesignSystem")], swiftSettings: [.swiftLanguageMode(.v5)]),
.testTarget(name: "WordPressFluxTests", dependencies: ["WordPressFlux"], swiftSettings: [.swiftLanguageMode(.v5)]),
.testTarget(
name: "WordPressFluxTests",
dependencies: ["WordPressFlux"],
exclude: ["WordPressFluxTests.xctestplan"],
swiftSettings: [.swiftLanguageMode(.v5)]
),
.testTarget(name: "AsyncImageKitTests", dependencies: [
.target(name: "AsyncImageKit"),
.target(name: "WordPressTesting"),
Expand Down
24 changes: 24 additions & 0 deletions Modules/Tests/WordPressFluxTests/WordPressFluxTests.xctestplan
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
{
"configurations" : [
{
"id" : "92A65F35-8051-4F5F-B68A-1802B2E06105",
"name" : "Test Scheme Action",
"options" : {

}
}
],
"defaultOptions" : {
"codeCoverage" : false
},
"testTargets" : [
{
"target" : {
"containerPath" : "container:",
"identifier" : "WordPressFluxTests",
"name" : "WordPressFluxTests"
}
}
],
"version" : 1
}
2 changes: 1 addition & 1 deletion Scripts/BuildPhases/GenerateCredentials.xcfilelist
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,4 @@ ${SRCROOT}/Credentials/Secrets-example.swift

# Add the script that uses this file as a source, so that, if the script
# changes, Xcode will run it again on the next build.
${SRCROOT}/../Scripts/BuildPhases/ApplyConfiguration.sh
${SRCROOT}/Scripts/BuildPhases/ApplyConfiguration.sh
7 changes: 0 additions & 7 deletions Tests/KeystoneTests/WordPressUnitTests.xctestplan
Original file line number Diff line number Diff line change
Expand Up @@ -32,15 +32,13 @@
},
"testTargets" : [
{
"enabled" : false,
"target" : {
"containerPath" : "container:..\/Modules",
"identifier" : "AsyncImageKitTests",
"name" : "AsyncImageKitTests"
}
},
{
"enabled" : false,
"target" : {
"containerPath" : "container:WordPress.xcodeproj",
"identifier" : "4AD953BA2C21451700D0EEFA",
Expand All @@ -62,39 +60,34 @@
}
},
{
"enabled" : false,
"target" : {
"containerPath" : "container:..\/Modules",
"identifier" : "WordPressUIUnitTests",
"name" : "WordPressUIUnitTests"
}
},
{
"enabled" : false,
"target" : {
"containerPath" : "container:..\/Modules",
"identifier" : "WordPressSharedTests",
"name" : "WordPressSharedTests"
}
},
{
"enabled" : false,
"target" : {
"containerPath" : "container:..\/Modules",
"identifier" : "JetpackStatsWidgetsCoreTests",
"name" : "JetpackStatsWidgetsCoreTests"
}
},
{
"enabled" : false,
"target" : {
"containerPath" : "container:..\/Modules",
"identifier" : "WordPressFluxTests",
"name" : "WordPressFluxTests"
}
},
{
"enabled" : false,
"target" : {
"containerPath" : "container:..\/Modules",
"identifier" : "WordPressSharedObjCTests",
Expand Down
Loading