Skip to content

Merge finalized release 20.6 into trunk #19275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 5, 2022
Merged

Merge finalized release 20.6 into trunk #19275

merged 6 commits into from
Sep 5, 2022

Conversation

mokagio
Copy link
Contributor

@mokagio mokagio commented Sep 2, 2022

  • Fastlane localized release_notes.txt updates
  • Localized .strings updates
  • Build number bump in version .xcconfig file

Notice the additional "update metadata translations," there were missing release notes at the time I launched the deploy, and as a matter of fact, he fr-FR release notes are still missing.

Also notice the "new" tr metadata for WordPress. This is a "fix" from what noted in #19267 (comment). The same goes for 7c3289f (#19275).

ASC metadata still get deleted when we get 429 because gp_downloadmetadata was not part of wordpress-mobile/release-toolkit#402 and didn't get the handy retry logic.

mokagio and others added 6 commits September 2, 2022 16:34
These were deleted during the last `gp_downloadmetadata` likely because
of a 429 error from GlotPress.

Various GlotPress actions were updated to retry when receiving a 429 in
wordpress-mobile/release-toolkit#402, but
`gp_downloadmetadata` was not one of them.
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Sep 2, 2022

You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19275-7c3289f on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@mokagio mokagio marked this pull request as ready for review September 2, 2022 11:48
@mokagio mokagio self-assigned this Sep 2, 2022
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Sep 2, 2022

You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19275-7c3289f on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@mokagio mokagio added this to the 20.7 milestone Sep 2, 2022
@mokagio mokagio requested a review from a team September 2, 2022 11:49
Copy link
Contributor

@AliSoftware AliSoftware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Version bump in .xcconfig files
  • Latest app and metadata translations pulled from GlotPress

:shipit:

@mokagio mokagio merged commit 4817090 into trunk Sep 5, 2022
@mokagio mokagio deleted the release/20.6 branch September 5, 2022 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants