Skip to content

[PhotonUtils] Add AVIF scenario handling #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

ThomazFB
Copy link
Contributor

@ThomazFB ThomazFB commented Oct 29, 2024

Summary

This PR adjusts the PhotonUtils URL logic to account for avif formats. Since they don't load using the alternative path branching from https://i0.wp.com/, when the avif format is detected, the URL will be returned only with the addition of the query parameters.

How to Test

Since this change is targeting to provide AVIF support to the WCAndroid app, I suggest testing it through the Woo counterpart PR: woocommerce/woocommerce-android#12835

@ThomazFB ThomazFB marked this pull request as ready for review October 29, 2024 16:52
@ThomazFB ThomazFB requested a review from atorresveiga October 29, 2024 16:58
Copy link

@atorresveiga atorresveiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@ThomazFB ThomazFB merged commit ea88675 into trunk Oct 30, 2024
8 checks passed
@ThomazFB ThomazFB deleted the issue/add-avif-detection-to-photon-utils branch October 30, 2024 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants