Skip to content

[Dependency Analysis] Remove Unused Dependencies #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 14, 2024
Merged

[Dependency Analysis] Remove Unused Dependencies #151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
bf390a2
Deps: Update dependency analysis to 1.33.0
ParaskP7 Aug 12, 2024
d69b478
Deps: Remove unused androidx test ext junit dependency on android test
ParaskP7 Aug 13, 2024
f597b55
Deps: Remove unused androidx test rule dependency on android test
ParaskP7 Aug 13, 2024
940ca50
Deps: Replace androidx core ktx dependency with plain core
ParaskP7 Aug 13, 2024
709f7a4
Deps: Remove unused volley dependency
ParaskP7 Aug 13, 2024
95e4749
Refactor: Rename volley error msg to plain error msg for app log e func
ParaskP7 Aug 13, 2024
661d131
Deps: Replace eventbus dependency with eventbus java
ParaskP7 Aug 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions WordPressUtils/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,12 @@ repositories {

dependencies {
implementation "org.apache.commons:commons-text:$commonsTextVersion"
implementation "com.android.volley:volley:$volleyVersion"
implementation "com.google.android.material:material:$materialVersion"
implementation "androidx.swiperefreshlayout:swiperefreshlayout:$androidxSwipeRefreshLayoutVersion"
implementation "androidx.recyclerview:recyclerview:$androidxRecyclerViewVersion"
implementation "org.greenrobot:eventbus:$eventBusVersion"
implementation "org.greenrobot:eventbus-java:$eventBusVersion"

implementation "androidx.core:core-ktx:$androidxCoreVersion"
implementation "androidx.core:core:$androidxCoreVersion"

testImplementation "junit:junit:$junitVersion"
testImplementation "org.assertj:assertj-core:$assertjVersion"
Expand All @@ -28,8 +27,6 @@ dependencies {
lintChecks "org.wordpress:lint:$wordpressLintVersion"

androidTestImplementation "androidx.test:runner:$androidxTestCoreVersion"
androidTestImplementation "androidx.test:rules:$androidxTestCoreVersion"
androidTestImplementation "androidx.test.ext:junit:$jUnitExtVersion"
}

android {
Expand Down
10 changes: 5 additions & 5 deletions WordPressUtils/src/main/java/org/wordpress/android/util/AppLog.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,18 +205,18 @@ public static void e(T tag, Throwable tr) {
* Sends a ERROR log message
* @param tag Used to identify the source of a log message. It usually identifies the class or activity where the
* log call occurs.
* @param volleyErrorMsg
* @param errorMsg
* @param statusCode
*/
public static void e(T tag, String volleyErrorMsg, int statusCode) {
if (TextUtils.isEmpty(volleyErrorMsg)) {
public static void e(T tag, String errorMsg, int statusCode) {
if (TextUtils.isEmpty(errorMsg)) {
return;
}
String logText;
if (statusCode == -1) {
logText = volleyErrorMsg;
logText = errorMsg;
} else {
logText = volleyErrorMsg + ", status " + statusCode;
logText = errorMsg + ", status " + statusCode;
}
Log.e(TAG + "-" + tag.toString(), logText);
addEntry(tag, LogLevel.w, logText);
Expand Down
4 changes: 0 additions & 4 deletions build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,14 +46,10 @@ ext {
commonsTextVersion = '1.10.0'
eventBusVersion = '3.3.1'
materialVersion = '1.2.1'
volleyVersion = '1.2.0'

// test
androidxTestCoreVersion = '1.4.0'
assertjVersion = '3.11.1'
junitVersion = '4.12'
robolectricVersion = '4.9'

// android test
jUnitExtVersion = '1.1.3'
}
2 changes: 1 addition & 1 deletion settings.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ pluginManagement {
gradle.ext.kotlinVersion = '1.9.24'
gradle.ext.agpVersion = '8.1.0'
gradle.ext.automatticPublishToS3Version = '0.9.0'
gradle.ext.dependencyAnalysisVersion = '1.28.0'
gradle.ext.dependencyAnalysisVersion = '1.33.0'

plugins {
id "org.jetbrains.kotlin.android" version gradle.ext.kotlinVersion
Expand Down
Loading