This repository was archived by the owner on Feb 4, 2025. It is now read-only.
Coupons/fetch reports #3012
Merged
Coupons/fetch reports #3012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hichamboushaba
commented
May 15, 2024
| PLUGIN_NOT_ACTIVE, | ||
| API_NOT_FOUND, |
There was a problem hiding this comment.
I was the one who introduced PLUGIN_NOT_ACTIVE during the REST API project, it was to match the value emitted by the Order REST client, but I think that name was not the right choice, the error could happen for any non-existing endpoint, be it because the plugin is not active, or any other reason, so I renamed it to make it more clear, please let me know what you think?
And this is a breaking change for WCAndroid, so let's not merge this until the WCAndroid PR is ready.
hichamboushaba
commented
May 15, 2024
|
|
||
| NOT_FOUND -> { | ||
| when (apiError) { | ||
| "rest_no_route" -> WooErrorType.API_NOT_FOUND |
There was a problem hiding this comment.
We need this specific differentiation now, the new error type will help identify when the wc-analytics endpoint is not available.
hichamboushaba
force-pushed
the
coupons/fetch-reports
branch
from
a48cb8c to
2847b97
Compare
1 task
hichamboushaba
force-pushed
the
coupons/fetch-reports
branch
from
2847b97 to
52cd84a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes woocommerce/woocommerce-android#11518
This PR adds the networking implementation needed for the coupons card in the dynamic dashboard.
Testing
Also check woocommerce/woocommerce-android#11531 for testing the other changes.