-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Convert reader post list activity to Kotlin #21842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert reader post list activity to Kotlin #21842
Conversation
Generated by 🚫 Danger |
|
App Name | ![]() |
|
Flavor | Jalapeno | |
Build Type | Debug | |
Version | pr21842-2e6b55c | |
Commit | 2e6b55c | |
Direct Download | jetpack-prototype-build-pr21842-2e6b55c.apk |
|
App Name | ![]() |
|
Flavor | Jalapeno | |
Build Type | Debug | |
Version | pr21842-2e6b55c | |
Commit | 2e6b55c | |
Direct Download | wordpress-prototype-build-pr21842-2e6b55c.apk |
Project manifest changes for WordPressThe following changes in the --- ./build/reports/diff_manifest/WordPress/wordpressVanillaRelease/base_manifest.txt 2025-04-30 14:59:16.984390391 +0000
+++ ./build/reports/diff_manifest/WordPress/wordpressVanillaRelease/head_manifest.txt 2025-04-30 14:59:19.294391578 +0000
@@ -648,7 +648,7 @@
android:theme="@style/WordPress.NoActionBar" />
<activity
android:name="org.wordpress.android.ui.reader.ReaderSubsActivity"
- android:theme="@style/WordPress.NoActionBar"
+ android:theme="@style/WordPress.NoActionBar.NoEdgeToEdge"
android:windowSoftInputMode="stateHidden" />
<activity
android:name="org.wordpress.android.ui.reader.ReaderPhotoViewerActivity" Go to https://buildkite.com/automattic/wordpress-android/builds/21758/canvas?sid=01968731-d213-4a67-acfe-d2a9e19c6ba8, click on the |
Project manifest changes for WordPressThe following changes in the --- ./build/reports/diff_manifest/WordPress/jetpackVanillaRelease/base_manifest.txt 2025-04-30 14:59:32.277352360 +0000
+++ ./build/reports/diff_manifest/WordPress/jetpackVanillaRelease/head_manifest.txt 2025-04-30 14:59:34.297342427 +0000
@@ -675,7 +675,7 @@
android:theme="@style/WordPress.NoActionBar" />
<activity
android:name="org.wordpress.android.ui.reader.ReaderSubsActivity"
- android:theme="@style/WordPress.NoActionBar"
+ android:theme="@style/WordPress.NoActionBar.NoEdgeToEdge"
android:windowSoftInputMode="stateHidden" />
<activity
android:name="org.wordpress.android.ui.reader.ReaderPhotoViewerActivity" Go to https://buildkite.com/automattic/wordpress-android/builds/21758/canvas?sid=01968731-d214-4aea-8402-06e568e306d6, click on the |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## trunk #21842 +/- ##
=======================================
Coverage 39.39% 39.39%
=======================================
Files 2132 2132
Lines 99994 99994
Branches 15398 15398
=======================================
Hits 39397 39397
Misses 57115 57115
Partials 3482 3482 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
WordPress/src/main/java/org/wordpress/android/ui/reader/ReaderPostListActivity.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and works as expected!
Screen_recording_20250430_095744.mp4
|
Partially addresses CMM-307
I had intended to convert
ReaderPostListActivity
andReaderPostListFragment
to Kotlin in a single PR, but the latter turned out to be far more involved than expected. Because of this, I decided to handle them in separate PRs. In this PR, the activity is addressed.Test A:
Test B
Notes:
findViewById
because they involve views not in the activity itselfonActivityResult
. That had to remain because we usestartActivityForResult
outside of this activity (for example, inReaderActivityLauncher
)