Skip to content

Revert introduction of lightweight objects for safety #15807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2025

Conversation

itsmeichigo
Copy link
Contributor

@itsmeichigo itsmeichigo commented Jun 24, 2025

Part of WOOMOB-619

Description

Due to concerns about safety, this PR reverts changes made in #15774. We'll find another solution that is less error prone in a separate PR.

Testing steps

Follow the instructions in #15774 to confirm that affected areas work correctly.

Testing information

  • Searched the codebase and confirmed that the concept of lightweight objects are completely gone.
  • Ran the app on simulator iPhone 16 iOS 18.4 and confirmed that all the following parts work correctly:
    • Product list + product details
    • Order list + order details
    • Dashboard
    • Blaze campaign creation
    • New shipping label creation flow.

Screenshots

N/A


  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@itsmeichigo itsmeichigo added this to the 22.7 milestone Jun 24, 2025
@itsmeichigo itsmeichigo added feature: core Core work. See "category: tooling" and "category: architecture" Enhancement labels Jun 24, 2025
@itsmeichigo itsmeichigo marked this pull request as ready for review June 24, 2025 10:00
@wpmobilebot
Copy link
Collaborator

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Number30691
VersionPR #15807
Bundle IDcom.automattic.alpha.woocommerce
Commit82fe38a
Installation URL10eknspcfiplg
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@itsmeichigo itsmeichigo enabled auto-merge June 24, 2025 10:05
Copy link
Contributor

@joshheald joshheald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It'd be great to get those performance benefits, but I think this slower approach is better 👍

@itsmeichigo itsmeichigo merged commit 09b4002 into trunk Jun 24, 2025
24 checks passed
@itsmeichigo itsmeichigo deleted the woomob-619-revert-lightweight-objects branch June 24, 2025 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement feature: core Core work. See "category: tooling" and "category: architecture"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants