-
Notifications
You must be signed in to change notification settings - Fork 117
[Woo POS] Improve VoiceOver accessibility for barcode scanning errors #15793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
staskus
wants to merge
7
commits into
trunk
Choose a base branch
from
woomob-652-woo-posbarcodes-voice-over-improvements
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add playSound method with completion parameter - Implement AVAudioPlayerDelegate for precise sound finish detection - Maintain backward compatibility with existing playSound calls - Enable VoiceOver announcements after sound playback completes
- Add optional accessibilityLabel property to Cart.PurchasableItem - Generate accessibility labels for barcode scan errors with format "Error description. Barcode" - Update ItemRowView to use custom accessibility labels for VoiceOver - Maintain default behavior for normal cart items
- Import UIKit for UIAccessibility support - Use sound player completion callback to trigger VoiceOver announcements - Announce accessibility labels after barcode scan failure sounds complete - Improve accessibility feedback for scanning errors
- Add accessibilityFocusedItemID property to Cart model - Implement @AccessibilityFocusState in CartView for native VoiceOver focus - Replace UIAccessibility.post with accessibility focus on error items after sound - Remove UIKit dependency from PointOfSaleAggregateModel - Use proper SwiftUI accessibility patterns for better user experience
- Add accessibility labels to replace bullet point characters with sequential indicators - Create screen reader-friendly versions using "First:", "Second:", etc. instead of "•" - Preserve visual bullet points for sighted users while improving screen reader experience - Add proper localization for accessible text alternatives
Generated by 🚫 Danger |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WOOMOB-652
Description
This PR improves VoiceOver accessibility for barcode scanning errors in Woo POS. When barcode scanning fails, users will now receive audio feedback with accessibility focusing on a cart item row.
The implementation addresses several accessibility gaps:
Additionally
Steps to reproduce
Testing information
Tested on iPad Air M2 18.3 with VoiceOver enabled.
RELEASE-NOTES.txt
if necessary.