[Woo POS][Barcodes] Dark mode: corners and background when loading #15792
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, the loading rows didn’t match the product rows, especially in dark mode.
This PR ensures that the rounded corners are shown, and a background shown in both modes.
The issue was that we relied on the ghost cell applying the border styles, but that was too low down the stack. We also relied on it for the background colour, which we now pass in through the configuration so it can be different for the cart and item list (which have different backgrounds themselves.)
Steps to reproduce
Testing information
In dark mode, add a product by scanning a barcode (or mashing keys ending in the enter button.)
Observe that you can see the rounded corners, and the background doesn't change in when it loads.
Also check the item list when opening a variable product or loading the next page – the loading cells should not have changed.
Screenshots
rounded.corners.and.background.in.dark.mode.mp4
RELEASE-NOTES.txt
if necessary.