Skip to content

[Woo POS][Barcodes] Dark mode: corners and background when loading #15792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

joshheald
Copy link
Contributor

@joshheald joshheald commented Jun 20, 2025

Description

Previously, the loading rows didn’t match the product rows, especially in dark mode.

This PR ensures that the rounded corners are shown, and a background shown in both modes.

The issue was that we relied on the ghost cell applying the border styles, but that was too low down the stack. We also relied on it for the background colour, which we now pass in through the configuration so it can be different for the cart and item list (which have different backgrounds themselves.)

Steps to reproduce

Testing information

In dark mode, add a product by scanning a barcode (or mashing keys ending in the enter button.)
Observe that you can see the rounded corners, and the background doesn't change in when it loads.

Also check the item list when opening a variable product or loading the next page – the loading cells should not have changed.

Screenshots

rounded.corners.and.background.in.dark.mode.mp4

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Previously, the loading rows didn’t match the product rows, especially in dark mode.

This commit ensures that the rounded corners are shown, and a background shown in both modes.
@joshheald joshheald added this to the 22.7 milestone Jun 20, 2025
@joshheald joshheald requested a review from staskus June 20, 2025 11:32
@joshheald joshheald added type: task An internally driven task. feature: POS labels Jun 20, 2025
@wpmobilebot
Copy link
Collaborator

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Number30629
VersionPR #15792
Bundle IDcom.automattic.alpha.woocommerce
Commitce81379
Installation URL3se828it64ka0
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

Copy link
Contributor

@staskus staskus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'll be good to combine it with #15791 changes. It adds the corners but doesn't address the background color. I can deal with integrating after merging this.

@joshheald joshheald merged commit c9f34ca into trunk Jun 20, 2025
21 of 23 checks passed
@joshheald joshheald deleted the woomob-653-woo-posbarcodes-loading-cart-items-should-have-rounded branch June 20, 2025 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: POS type: task An internally driven task.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants