Skip to content

AINFRA-780 - Make HardwareTests a Swift package test target #15789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

mokagio
Copy link
Contributor

@mokagio mokagio commented Jun 20, 2025

Description

Now that all the frameworks sources are Swift packages (targets in the same Swift package to be precise) we can move the tests there, too. We didn't do that all in one go to avoid big diffs.

Notice:

  • The whole Hardware/ folder has been removed, including the dedicated Xcode project
  • No changes in the test code

Testing information

See green CI.

Additionally, you can run the focused Hardware tests by selecting the Hardware scheme from Xcode.

Screenshots


  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@dangermattic
Copy link
Collaborator

dangermattic commented Jun 20, 2025

2 Warnings
⚠️ Modules/Package.swift was changed without updating its corresponding Package.resolved. Please resolve the Swift packages as appropriate to your project setup (e.g. in Xcode or by running swift package resolve).
⚠️ This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

@mokagio mokagio marked this pull request as ready for review June 20, 2025 08:19
@mokagio mokagio added this to the 22.7 milestone Jun 20, 2025
@mokagio mokagio self-assigned this Jun 20, 2025
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jun 20, 2025

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Number30638
VersionPR #15789
Bundle IDcom.automattic.alpha.woocommerce
Commit1ba1d09
Installation URL2phllgsqtpni0
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@mokagio mokagio force-pushed the ainfra-780-move-hardwaretests-to-modules branch from 2b8f0ed to 7757ce3 Compare June 20, 2025 08:22
@mokagio mokagio requested review from a team June 20, 2025 20:32
@mokagio mokagio enabled auto-merge June 20, 2025 21:02
@mokagio mokagio force-pushed the ainfra-780-move-hardwaretests-to-modules branch from 7757ce3 to 1ba1d09 Compare June 21, 2025 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants