Skip to content

[App size reduction] Remove domain purchase remaining logic #15787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 20, 2025

Conversation

iamgabrielma
Copy link
Contributor

@iamgabrielma iamgabrielma commented Jun 20, 2025

Continuation of #15754 and WOOMOB-534

Description

In the previous PR we removed the unused code around domain purchases in the WooCommerce target, in this PR we remove the remaining code in Yosemite and Networking.

Testing information

  • CI should pass
  • From my understanding of this feature, we should still see no Domains row under Menu tab > Settings, on a WPCom test store without a custom domain, and no ability to purchase a domain through the app.

@dangermattic
Copy link
Collaborator

dangermattic commented Jun 20, 2025

1 Warning
⚠️ This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
1 Message
📖

This PR contains changes to Tracks-related logic. Please ensure (author and reviewer) the following are completed:

  • The tracks events must be validated in the Tracks system.
  • Verify the internal Tracks spreadsheet has also been updated.
  • Please consider registering any new events.
  • The PR must be assigned the category: tracks label.

Generated by 🚫 Danger

@iamgabrielma iamgabrielma added type: task An internally driven task. feature: in-app purchases Related to In-app purchases and subscriptions labels Jun 20, 2025
@iamgabrielma iamgabrielma added this to the 22.7 milestone Jun 20, 2025
@iamgabrielma iamgabrielma added the category: tracks Related to analytics, including Tracks Events. label Jun 20, 2025
@wpmobilebot
Copy link
Collaborator

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Number30611
VersionPR #15787
Bundle IDcom.automattic.alpha.woocommerce
Commitbd06297
Installation URL2dbk6qi0u8b4o
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@iamgabrielma
Copy link
Contributor Author

Adding you as a reviewer for now to trigger CI @itsmeichigo , as I have troubles building the project with the latests infra changes to confirm all is good. No need to review the changes yet.

@iamgabrielma iamgabrielma requested a review from itsmeichigo June 20, 2025 05:19
@iamgabrielma iamgabrielma marked this pull request as ready for review June 20, 2025 05:19
@iamgabrielma
Copy link
Contributor Author

This is ready for review, I'm not acquainted with the feature so please let me know if there's something off 🙇

Most likely we can remove PaymentStore/Action as well, since we don't sell plans neither, but I've kept this outside of the scope for this one.

@itsmeichigo itsmeichigo self-assigned this Jun 20, 2025
Copy link
Contributor

@itsmeichigo itsmeichigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up!

@iamgabrielma iamgabrielma merged commit ca9d60b into trunk Jun 20, 2025
30 checks passed
@iamgabrielma iamgabrielma deleted the task/part-of-woomob534-remove-domain-feat-v2 branch June 20, 2025 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: tracks Related to analytics, including Tracks Events. feature: in-app purchases Related to In-app purchases and subscriptions type: task An internally driven task.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants