Remove favoriteProducts feature flag

[joshheald]

Description

This PR removes the favourite products feature flag, which was released a long time ago.

Steps to reproduce

1. Launch the app and open the Products tab
2. Check that you can still filter by favourite products
3. Check that you can still mark a product as favourite (using the ... menu)

---

• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

[wpmobilebot]

📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce iOS Prototype
	Build Number	30665
	Version	PR #15786
	Bundle ID	com.automattic.alpha.woocommerce
	Commit	7c56b3b
	Installation URL	2ft1la1p80dhg

Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

[jaclync]

LGTM! TIL about the favorite products feature 😅 Some observations, I'm not sure if it's a feature we're actively maintaining though:

• The CTA felt a bit hidden, I was expecting a heart or similar icon/CTA in the product details page like in most of the apps.
• If the product list is filtered by favorite products only in a split view like on tablets, the favorite action from a unfavorite product before the filtering doesn't add the product to the list until clearing the filter and applying the favorite filter again.

[joshheald]

LGTM! TIL about the favorite products feature 😅 Some observations, I'm not sure if it's a feature we're actively maintaining though:

• The CTA felt a bit hidden, I was expecting a heart or similar icon/CTA in the product details page like in most of the apps.
• If the product list is filtered by favorite products only in a split view like on tablets, the favorite action from a unfavorite product before the filtering doesn't add the product to the list until clearing the filter and applying the favorite filter again.

Thanks for the review 😊

I agree with you, but I don't think we're going to put time in to this just now. It's an old HACK week project from Sharma, only on iOS.

If we did more with it, the value should be synced to the products on the site.