[Woo POS] Prevent connection success flashing during payment

[joshheald]

Description

This PR prevents the Connection success modal from showing when a reader is connected on the Check Out screen. This is because we immediately start payment in that situation, so the success confirmation is unnecessary and distracting, and may only flash up briefly anyway.

Steps to reproduce

1. Launch the app and open POS
2. Add something to your cart
3. Check out
4. Tap Connect your reader
5. Observe that the Connection success modal is not shown and payment is taken
6. Tap New order when the payment is complete
7. Disconnect your reader
8. Reconnect your reader
9. Observe that the Connection success modal is shown in this case.

Testing information

I've tested on an iPad Air simulator running iOS 18.5, using the simulated reader, and an iPad Air running iOS 17.7.2 with a real reader.

Screenshots

connection.mp4

---

• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

[wpmobilebot]

📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce iOS Prototype
	Build Number	30635
	Version	PR #15784
	Bundle ID	com.automattic.alpha.woocommerce
	Commit	834628b
	Installation URL	7ubmk6pauqa5g

Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

[staskus]

👍 The success message is no longer visible if reader connection happens during the payment.

[staskus]

Would this business logic benefit from being covered with a test?

[joshheald]

14a9dd5