-
Notifications
You must be signed in to change notification settings - Fork 117
[Shipping Labels] M4 accessibility layout issues #15783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and confirmed that most of the fixes look good on my iPhone 16 Pro device with large accessibility fonts. I found an issue with the customs row:

Here the labels are clipped off to multiple lines, which is not very readable. How about using SwiftUI's ViewThatFits
with 2 layout options:
a. HStack with all items
b. HStack with the Edit button and a VStack containing the title and the badge.
Regarding the change to the notice of missing destination address, when a really large font size is used, the bottom sheet covers most of the screen making it hard to scroll through the content underneath. I'd suggest hiding the Purchase button when it's not enabled:

Even with the purchase button hidden, the view beneath can still be inacessible if there are more notices (i.e. unverified origin address or missing ITN field in the customs form). Should we have a logic to prioritize and show only one notice at a time?
I found some more layout issues that were not listed - I added them in the accessibility audit doc so they can be addressed in a separate PR.
Done in 2f43ef4
Done in 0953bdd
Done in a9cece2 Also made sure the "Order details" title fits just in 1 line: a9cece2 |
WOOMOB-617
Description
Addresses accessibility Shipping Labels layout issues listed in 1nxDAV51DK_l8opZ2ZznqaA3FpfiYPoWZPd38HA4TTys-gdoc
Known / Remaining issues
Steps to reproduce
CustomerNoteTableViewCell.xib
. Removes redundant constraints and removes height restriction to unlock multiline content for accessibility scales.Picker
is not scalable according to dynamic font sizes. Replaces thePicker
conditionally withTopTabView
when thedynamicSize
becomesisAccessibility
Testing information
The testing requires Shipping plugin and the accessibility font size adjustment.
No >
positioned horizontally.Before:

After:
Simulator.Screen.Recording.-.iPhone.16.-.2025-06-19.at.13.30.37.mov
RELEASE-NOTES.txt
if necessary.