Skip to content

[Orders] Add ShippingLineRowView for order shipping lines #12822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2024

Conversation

rachelmcr
Copy link
Contributor

Part of: #12582

Why

This adds a SwiftUI view for shipping lines in the order creation/editing form and order details.

How

Since we know we'll want to show a similar view in both places, I created this as a SwiftUI view that we can display in order details using a UIHostingConfiguration in a UITableViewCell.

The layout is similar to the CustomAmountRowView and it might be worth eventually creating a more reusable row view that supports a title, optional subtitle, value, and edit button.

Testing instructions

This view is not yet used in the UI. Different device configurations (color scheme, orientation, dynamic type) can be tested in the SwiftUI preview.

Screenshots

Editable Not editable
Screenshot 2024-05-23 at 17 04 19 Screenshot 2024-05-23 at 17 04 30

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@rachelmcr rachelmcr added feature: order details Related to order details. feature: order creation All tasks related to creating an order labels May 23, 2024
@rachelmcr rachelmcr added this to the 18.8 milestone May 23, 2024
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is assigned to the milestone 18.8. This milestone is due in less than 2 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr12822-16e1ea0
Version18.7
Bundle IDcom.automattic.alpha.woocommerce
Commit16e1ea0
App Center BuildWooCommerce - Prototype Builds #9222
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@rachelmcr rachelmcr merged commit 24e3621 into trunk May 23, 2024
29 of 31 checks passed
@rachelmcr rachelmcr deleted the issue/12582-shipping-line-row-view branch May 23, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: order creation All tasks related to creating an order feature: order details Related to order details.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants