Skip to content

Dynamic Dashboard: Preserve existing ordering when refreshing cards. #12811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2024

Conversation

hafizrahman
Copy link
Contributor

Closes: #12743

Description

Previously, when refreshing Dashboard when there's a mix of default and new cards, the default cards will always be shown at the top again even if the new cards were set to be displayed at the top previously.

This PR fixes that so the user's cards ordering is preserved.

Testing instructions

  1. Start app
  2. Edit dashboard, then enable and put an m2 card (e.g: Inbox or Coupons) at the top of the list,
  3. Save,
  4. On the dashboard, do a pull-to-refresh
  5. Ensure that the enabled m2 card on step 2 stays at the top.
  6. restart app
  7. Ensure that the enabled m2 card on step 2 stays at the top.

@hafizrahman hafizrahman added the type: task An internally driven task. label May 22, 2024
@hafizrahman hafizrahman added this to the 18.8 milestone May 22, 2024
@hafizrahman hafizrahman marked this pull request as ready for review May 22, 2024 11:51
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is assigned to the milestone 18.8. This milestone is due in less than 2 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr12811-446709b
Version18.7
Bundle IDcom.automattic.alpha.woocommerce
Commit446709b
App Center BuildWooCommerce - Prototype Builds #9200
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@itsmeichigo itsmeichigo self-assigned this May 22, 2024
Copy link
Contributor

@itsmeichigo itsmeichigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix! 💯 This has been bothering me since yesterday!

@hafizrahman hafizrahman merged commit d0221ef into trunk May 22, 2024
27 checks passed
@hafizrahman hafizrahman deleted the feat/12743-preserve-saved-card-ordering branch May 22, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task An internally driven task.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When checking for saved cards settings, take into account card ordering also
4 participants