-
Notifications
You must be signed in to change notification settings - Fork 117
[Woo POS] Update POS menu item based on the latest design #12793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Generated by 🚫 Danger |
|
/// Play square image | ||
/// | ||
static var playSquareImage: UIImage { | ||
UIImage(systemName: "play.square")! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was looking at other systems icons and thinking maybe "creditcard" or some of it variations would fit better? Play button maybe indicates more that some video or something will be started. This icon will be hard to define since we are starting a special mode and not just showing a basic screen (normal indicator). Hm...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit unsure about the credit card mention because cash is also supported, I saw your comment in p91TBi-beb-p2#comment-12153 and we can wait for the final design decision. There's a separate subtask in #12779 to make any design updates from the entry point p2.
Part of #12779
Why
Now that we have the design for the POS menu item in p91TBi-beb-p2, we can update it in the app. Please note that more design updates might be coming based on the p2 comments, I added a subtask to #12779 to address them after the design is finalized.
How
pointOfSaleImage
from the asset, andplaySquareImage
from SF symbolsHubMenuViewModel.PointOfSaleEntryPoint
playSquareImage
in the accessory view of the POS row, a new case ofHubMenu.Row.Chevron
enum was added to show a play button in the accessory view instead of a chevron as the default. Originally I wanted to make it a configuration per row, but the enum is currently fileprivate in the view file and I decided to keep the changes minimumTesting instructions
Prerequisite: having a store eligible for POS
Screenshots
RELEASE-NOTES.txt
if necessary.