Skip to content

[Woo POS] Update POS menu item based on the latest design #12793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 22, 2024

Conversation

jaclync
Copy link
Contributor

@jaclync jaclync commented May 21, 2024

Part of #12779

Why

Now that we have the design for the POS menu item in p91TBi-beb-p2, we can update it in the app. Please note that more design updates might be coming based on the p2 comments, I added a subtask to #12779 to address them after the design is finalized.

How

  • Two new icons were added, pointOfSaleImage from the asset, and playSquareImage from SF symbols
  • The title, description, icon updates of the POS menu item are in HubMenuViewModel.PointOfSaleEntryPoint
  • For the playSquareImage in the accessory view of the POS row, a new case of HubMenu.Row.Chevron enum was added to show a play button in the accessory view instead of a chevron as the default. Originally I wanted to make it a configuration per row, but the enum is currently fileprivate in the view file and I decided to keep the changes minimum

Testing instructions

Prerequisite: having a store eligible for POS

  • Switch to a store in the prerequisite if needed
  • Go to the Menu tab
  • (If the POS row isn't shown yet) Turn on the feature switch in Menu > Settings > Experimental Features > POS, then revisit the Menu tab, if needed --> the POS row should look as in design

Screenshots

light dark

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@jaclync jaclync added status: feature-flagged Behind a feature flag. Milestone is not strongly held. feature: POS labels May 21, 2024
@jaclync jaclync added this to the 18.8 milestone May 21, 2024
@dangermattic
Copy link
Collaborator

1 Message
📖 This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr12793-447140e
Version18.7
Bundle IDcom.automattic.alpha.woocommerce
Commit447140e
App Center BuildWooCommerce - Prototype Builds #9155
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@jaclync jaclync marked this pull request as ready for review May 21, 2024 05:24
/// Play square image
///
static var playSquareImage: UIImage {
UIImage(systemName: "play.square")!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was looking at other systems icons and thinking maybe "creditcard" or some of it variations would fit better? Play button maybe indicates more that some video or something will be started. This icon will be hard to define since we are starting a special mode and not just showing a basic screen (normal indicator). Hm...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit unsure about the credit card mention because cash is also supported, I saw your comment in p91TBi-beb-p2#comment-12153 and we can wait for the final design decision. There's a separate subtask in #12779 to make any design updates from the entry point p2.

@jaclync jaclync merged commit 2e20685 into trunk May 22, 2024
31 checks passed
@jaclync jaclync deleted the feat/12779-update-pos-menu-item-design branch May 22, 2024 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: POS status: feature-flagged Behind a feature flag. Milestone is not strongly held.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants