-
Notifications
You must be signed in to change notification settings - Fork 117
[Woo POS] Update conditions for showing POS entry point #12783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
44 changes: 44 additions & 0 deletions
44
WooCommerce/Classes/ViewRelated/Dashboard/Settings/POS/POSEligibilityChecker.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| import Foundation | ||
| import UIKit | ||
| import class WooFoundation.CurrencySettings | ||
| import enum WooFoundation.CountryCode | ||
| import protocol Experiments.FeatureFlagService | ||
| import struct Yosemite.SiteSetting | ||
|
|
||
| /// Determines whether the POS entry point can be shown based on the selected store and feature gates. | ||
| final class POSEligibilityChecker { | ||
| private let cardPresentPaymentsOnboarding: CardPresentPaymentsOnboardingUseCaseProtocol | ||
| private let siteSettings: [SiteSetting] | ||
| private let currencySettings: CurrencySettings | ||
| private let featureFlagService: FeatureFlagService | ||
|
|
||
| init(cardPresentPaymentsOnboarding: CardPresentPaymentsOnboardingUseCaseProtocol = CardPresentPaymentsOnboardingUseCase(), | ||
| siteSettings: [SiteSetting] = ServiceLocator.selectedSiteSettings.siteSettings, | ||
| currencySettings: CurrencySettings = ServiceLocator.currencySettings, | ||
| featureFlagService: FeatureFlagService = ServiceLocator.featureFlagService) { | ||
| self.siteSettings = siteSettings | ||
| self.currencySettings = currencySettings | ||
| self.cardPresentPaymentsOnboarding = cardPresentPaymentsOnboarding | ||
| self.featureFlagService = featureFlagService | ||
| } | ||
|
|
||
| /// Returns whether the selected store is eligible for POS. | ||
| func isEligible() -> Bool { | ||
| // Always checks the main POS feature flag before any other checks. | ||
| guard featureFlagService.isFeatureFlagEnabled(.displayPointOfSaleToggle) else { | ||
| return false | ||
| } | ||
|
|
||
| let isCountryCodeUS = SiteAddress(siteSettings: siteSettings).countryCode == CountryCode.US | ||
| let isCurrencyUSD = currencySettings.currencyCode == .USD | ||
|
|
||
| // Tablet device | ||
| return UIDevice.current.userInterfaceIdiom == .pad | ||
| // Woo Payments plugin enabled and user setup complete | ||
| && (cardPresentPaymentsOnboarding.state == .completed(plugin: .wcPayOnly) || cardPresentPaymentsOnboarding.state == .completed(plugin: .wcPayPreferred)) | ||
| // USD currency | ||
| && isCurrencyUSD | ||
| // US store location | ||
| && isCountryCodeUS | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know if there are any performance effects when importing specific structs, enums, classes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think there's performance gain from this, but this makes it clear what the exact dependencies are if we ever want to move it to a framework.