Skip to content

[Watch] Share Currency Settings #12778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 20, 2024

Conversation

Ecarrion
Copy link
Contributor

closes #12777

Why

This PR shares the store currency settings with the watch to properly format the my store stats view.

How

  • Share and store watch dependencies (with updated currency settings)
  • Shared formatting code between widget and watch targets
  • Use stored currency settings to format content on the watch

Demo

USD PEN
usd pen

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@Ecarrion Ecarrion added this to the 18.8 milestone May 19, 2024
@Ecarrion Ecarrion linked an issue May 19, 2024 that may be closed by this pull request
@wpmobilebot
Copy link
Collaborator

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr12778-abed653
Version18.7
Bundle IDcom.automattic.alpha.woocommerce
Commitabed653
App Center BuildWooCommerce - Prototype Builds #9129
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@Ecarrion Ecarrion merged commit ebc4ad1 into ec/feature-watch-app May 20, 2024
22 checks passed
@Ecarrion Ecarrion deleted the issue/12777-share-currency-settings branch May 20, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Watch] Use store currency settings
2 participants