Skip to content

Fix: Overly Large Instruction Image on application password tutorial on iPad #12759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

pmusolino
Copy link
Contributor

Closes: #12732

Description

This PR resolves the issue reported in #12732, where the instructional image on application password tutorial on the iPad login page was excessively large, leading to a suboptimal user experience.

Changes

  • Set the maximum width of the instructional image to 400 px to ensure it fits within the designated area on the iPad screen.
  • Aligned the image to the left side of the login view to maintain consistency with the app's design language.

Testing Steps

  1. Cancel the app, so you can see the tutorial.
  2. Try to login into your store with the application password credentials, and you will see the application password tutorial.
  3. Check that the image is aligned on the left and it has the right size both on iPad and iPhone.

Screenshots

After on iPad After on iPhone
Simulator Screenshot - iPad Pro (11-inch) (4th generation) - 2024-05-16 at 18 40 44 Simulator Screenshot - iPhone 15 Pro Max - 2024-05-16 at 19 02 28

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@pmusolino pmusolino added type: bug A confirmed bug. feature: login Related to any part of the log in or sign in flow, or authentication. labels May 16, 2024
@pmusolino pmusolino added this to the 18.7 milestone May 16, 2024
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented May 16, 2024

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr12759-26b14e6
Version18.7
Bundle IDcom.automattic.alpha.woocommerce
Commit26b14e6
App Center BuildWooCommerce - Prototype Builds #9147
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@itsmeichigo itsmeichigo self-assigned this May 17, 2024
.resizable()
.aspectRatio(contentMode: .fit)
.frame(maxWidth: Layout.imageMaxWidth)
Spacer()
Copy link
Contributor

@itsmeichigo itsmeichigo May 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unsure about pushing the image to the left - it does look better on larger screen sizes but on iPhones the image might look better when center-aligned.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a comparison of how they appear pushing the image to the left. They looks good to me. Wdyt? Should I come back to the center alignment, or maybe have a custom rule just for iPad?

iPhone 15 Pro iPhone 15 Pro Max iPad Pro 11-inch
Screenshot 2024-05-17 at 11 48 52 Screenshot 2024-05-17 at 11 59 20 Screenshot 2024-05-17 at 11 49 13

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think keeping the image in the center looks in small screen sizes, while on large screens it's less distracting to be left-aligned. If it's not too complicated, having a separate alignment on large screens would be nice, otherwise I think center-aligned image looks better.

Copy link
Contributor Author

@pmusolino pmusolino May 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied the change here: 06edacc (centered the image for both iPhone and iPad)

Ready for another check 🙌

@itsmeichigo itsmeichigo modified the milestones: 18.7, 18.8 May 17, 2024
@pmusolino pmusolino requested a review from itsmeichigo May 20, 2024 12:20
Copy link
Contributor

@itsmeichigo itsmeichigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates!

@pmusolino pmusolino merged commit ae00e30 into trunk May 21, 2024
22 checks passed
@pmusolino pmusolino deleted the issue/12732-iPad-Login-Page-Instruction-Image-Overly-Large branch May 21, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: login Related to any part of the log in or sign in flow, or authentication. type: bug A confirmed bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iPad Login Page: Instruction Image Overly Large
3 participants