-
Notifications
You must be signed in to change notification settings - Fork 117
Fix: Overly Large Instruction Image on application password tutorial on iPad #12759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Overly Large Instruction Image on application password tutorial on iPad #12759
Conversation
|
.resizable() | ||
.aspectRatio(contentMode: .fit) | ||
.frame(maxWidth: Layout.imageMaxWidth) | ||
Spacer() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm unsure about pushing the image to the left - it does look better on larger screen sizes but on iPhones the image might look better when center-aligned.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think keeping the image in the center looks in small screen sizes, while on large screens it's less distracting to be left-aligned. If it's not too complicated, having a separate alignment on large screens would be nice, otherwise I think center-aligned image looks better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Applied the change here: 06edacc (centered the image for both iPhone and iPad)
Ready for another check 🙌
WooCommerce/Classes/Authentication/Application Password/ApplicationPasswordTutorial.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates!
Closes: #12732
Description
This PR resolves the issue reported in #12732, where the instructional image on application password tutorial on the iPad login page was excessively large, leading to a suboptimal user experience.
Changes
Testing Steps
Screenshots
RELEASE-NOTES.txt
if necessary.