-
Notifications
You must be signed in to change notification settings - Fork 117
[Min/Max Quantities Edit Support] UI + Sync Logic #12758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…riations' into issue/12718-min-max-quantities-edit-UI # Conflicts: # WooCommerce/Classes/ViewRelated/Products/Edit Product/EditableProductVariationModel.swift # WooCommerce/Classes/ViewRelated/Products/Edit Product/ProductFormViewModel.swift
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category: woo extensions
Related to WC extensions or plugins.
feature: product details
Related to adding or editing products, including Product Settings.
type: task
An internally driven task.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #12718
Description
With this PR we implement the edit support for Min/Max Quantities in the product and variations detail forms.
Testing instructions
Store without the Min/Max Quantities plugin installed. We don't show the Min/Max Quantities row in product and product variation details:
Store with the Min/Max Quantities plugin installed, but no values set in product. We show the Quantity Rules row with no rules:
Store with the Min/Max Quantities plugin installed, and values set in product. We show the Quantity Rules row with rules:
Quantity Rules screen shows values and placeholder when there is none:
Edit Quantity Rules:
Simulator.Screen.Recording.-.iPhone.15.-.2024-05-16.at.15.54.25.mp4
Product Variations:
We show the Quantity Rules row in product variations detail views if:
These two latter values can be set in
wp-admin
(Not in the app in this milestone)Simulator.Screen.Recording.-.iPhone.15.-.2024-05-16.at.16.22.08.mp4
Errors:
We show the errors messages returned from the requests. These are
As these errors are dynamic, we can test if we show the right message by debugging the code or inspecting the response with Proxyman. You can test the behavior with inconsistent input:
Example: Entering a min value bigger than the maximum:
Simulator.Screen.Recording.-.iPhone.15.-.2024-05-16.at.16.27.33.mp4
Screenshots
See above
RELEASE-NOTES.txt
if necessary.