-
Notifications
You must be signed in to change notification settings - Fork 131
Issue/woomob 370 handle displaying refunded shipments #14190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
irfano
wants to merge
4
commits into
trunk
Choose a base branch
from
issue/WOOMOB-370-handle-displaying-refunded-shipments
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Issue/woomob 370 handle displaying refunded shipments #14190
irfano
wants to merge
4
commits into
trunk
from
issue/WOOMOB-370-handle-displaying-refunded-shipments
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
49b7833
to
046388d
Compare
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #14190 +/- ##
============================================
+ Coverage 37.78% 37.83% +0.04%
+ Complexity 8933 8931 -2
============================================
Files 1956 1955 -1
Lines 109724 109676 -48
Branches 14390 14380 -10
============================================
+ Hits 41461 41491 +30
+ Misses 64472 64396 -76
+ Partials 3791 3789 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Base automatically changed from
issue/WOOMOB-370-shipping-label-refund-network
to
trunk
June 13, 2025 18:01
Previously, there were two separate models due to the "id" field being either a Long or a String. I’ve now combined them into one model by defining the id as a String. This allows us to parse the value as a string regardless of whether it’s originally a number or a string.
The button was previously hidden if all shipments were fulfilled. This change ensures that the "Create shipping label" button is always visible for orders that are eligible for shipping label creation, regardless of the fulfillment status of individual shipments.
ec078ef
to
88c3d65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of WOOMOB-373
Description
This PR makes following changes:
PurchasedLabelModel
andShippingLabelModel
. They were similar, but I initially created them as two models because one used a String type for theid
, and the other used an Int. I noticed that this string/int difference is not based on the endpoint, it's based on the shipment. In other words, even in same response, a shipment may have"id: 0"
and the next shipment may have"id": "small_box_id"
. This inconsistency is likely due to mobile platforms calling the purchase endpoint with the wrong ID type (I will fix this later and it's already discussed in p1749620015063859-slack-C05VBLKHHV1). In this PR, I've removedPurchasedLabelModel
and used stringid
inShippingLabelModel
. This way, we can support both string and number formats without any issue.Warning
Known issue: After refunding a label and navigating back to the main creation screen, the label is still being displayed as purchased. I’ll address this in a subsequent PR.
Steps to reproduce
The tests that have been performed
Steps above
Images/gif
RELEASE-NOTES.txt
if necessary. Use the "[Internal]" label for non-user-facing changes.