Fix for payment selection screen shown after successful payment

[samiuelson]

Closes: #10920

Description

There was a bug in navigation resulting in showing "Take payment" screen again after the payment was successfully collected (e.g. cash payment) after creating an order. The issue was present on large screens in tablet mode.

Steps to reproduce

Steps to reproduce the bug:

1. Go to order list
2. Start the order creation flow
3. Add a product or a custom amount
4. Tap on Collect Payment
5. Select Cash
6. Confirm
7. Press back
8. Notice the app navigates you back to the Payment Selection screen

Testing information

The tests should verify that after collecting the payment the app redirects to the order list screen (in phone mode) and to the orders with order details (in tablet mode). Pressing "back" should redirect to the "My store" screen.

The tests that have been performed

I tested the above scenario on phone and tablet physical devices: Pixel 8 and Galaxy Tab, Android 14.

Images/gif

Screen_recording_20240826_162709.mp4

• I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

• The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
• Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
• Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

[wpmobilebot]

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce-Wear Android
	Platform	⌚️ Wear OS
	Flavor	Jalapeno
	Build Type	Debug
	Commit	578860c
	Direct Download	woocommerce-wear-prototype-build-pr12415-578860c.apk

[wpmobilebot]

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce Android
	Platform	📱 Mobile
	Flavor	Jalapeno
	Build Type	Debug
	Commit	578860c
	Direct Download	woocommerce-prototype-build-pr12415-578860c.apk

[backwardstruck]

It seems to be working correctly in my testing, although the original issue was filed before I added the new change due calculator: #11606 so the repro steps are a little different.

[backwardstruck]

The code change looks fine to me. As the testing steps have changed a bit from the original issue, I'm not sure that I was able to reproduce it on trunk though. Happy to re-test on trunk with additional instructions.

[samiuelson]

The code change looks fine to me. As the testing steps have changed a bit from the original issue, I'm not sure that I was able to reproduce it on trunk though. Happy to re-test on trunk with additional instructions.

👋 @backwardstruck, thanks for review! Sure, I'm sending a video with the reproduction steps shown below:

Screen_recording_20240827_112911.mp4

[backwardstruck]

Thanks for the video @samiuelson I was able to repro on trunk and not in this branch. I see that I had not popped the back stack when adding that cash payment screen (since it was just a dialog before).

[samiuelson]

Thanks for the video @samiuelson I was able to repro on trunk and not in this branch. I see that I had not popped the back stack when adding that cash payment screen (since it was just a dialog before).

IMO, it was broken for a long time, even before the due change calculator was added.