Skip to content

[Tooling] Fix download of Wear Universal APK #11854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

AliSoftware
Copy link
Contributor

@AliSoftware AliSoftware commented Jun 28, 2024

Description

Fix issue when the creation of the GitHub Release for the Wear app tries to download the Universal APK from Google Play

We initially tried to fix that in #11786 but we missed a Ruby syntax subtlety that made a our fix not work as expected and always return an offset of 0

See: #11786 (comment)

Testing information

  • Change the lane from private_lane to lane
  • Comment out the call to create_release
  • Call bundle exec fastlane create_gh_release app:WooCommerce-Wear version:19.3
  • Check that the downloaded APK is the one from the Wear App, with a versionCode > 50000 and not the one for the Mobile app

Disclamer: I didn't test the fix myself (as I wrote the PR from my iPad) Tested this morning and it works.

@AliSoftware AliSoftware requested a review from iangmaia June 28, 2024 22:17
@AliSoftware AliSoftware self-assigned this Jun 28, 2024
@AliSoftware AliSoftware added the category: tooling Anything that involves building & maintaining the project, including scripts, `Fastfile`, etc. label Jun 28, 2024
@AliSoftware AliSoftware added this to the 19.3 ❄️ milestone Jun 28, 2024
@AliSoftware AliSoftware requested a review from ThomazFB June 28, 2024 22:18
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is assigned to the milestone 19.3 ❄️. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit3bd8c20
Direct Downloadwoocommerce-wear-prototype-build-pr11854-3bd8c20.apk

@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit3bd8c20
Direct Downloadwoocommerce-prototype-build-pr11854-3bd8c20.apk

@AliSoftware
Copy link
Contributor Author

Just ran the testing instructions this morning and confirmed via $ANDROID_SDK_ROOT/build-tools/34.0.0/aapt2 dump badging artifacts/WooCommerce-Wear-19.3-universal.apk that the downloaded APK when passing app:WooCommerce-Wear was the one for Wear indeed (versionCode='50567' versionName='19.3-rc-1w', uses-library:'com.google.android.wearable', …) 👍

@AliSoftware AliSoftware merged commit 2e0bb76 into release/19.3 Jul 1, 2024
17 checks passed
@AliSoftware AliSoftware deleted the tooling/fix-download-wear-apk branch July 1, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: tooling Anything that involves building & maintaining the project, including scripts, `Fastfile`, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants